Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1408)

Unified Diff: net/quic/quic_protocol.cc

Issue 2011653004: Remove obsolete fields in quic_protocol and their current usage in QUIC. Reorders QuicAckFrame fie… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@122721477
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/quic/quic_protocol.h ('k') | net/quic/quic_protocol_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_protocol.cc
diff --git a/net/quic/quic_protocol.cc b/net/quic/quic_protocol.cc
index a726870e16e7db34d34a63dc6b8e1abb8aa99c4e..0899876fe3bb5aac86c8cef514bbe486fb69525b 100644
--- a/net/quic/quic_protocol.cc
+++ b/net/quic/quic_protocol.cc
@@ -79,9 +79,7 @@ QuicPacketHeader::QuicPacketHeader()
path_id(kDefaultPathId),
entropy_flag(false),
entropy_hash(0),
- fec_flag(false),
- is_in_fec_group(NOT_IN_FEC_GROUP),
- fec_group(0) {}
+ fec_flag(false) {}
QuicPacketHeader::QuicPacketHeader(const QuicPacketPublicHeader& header)
: public_header(header),
@@ -89,9 +87,7 @@ QuicPacketHeader::QuicPacketHeader(const QuicPacketPublicHeader& header)
path_id(kDefaultPathId),
entropy_flag(false),
entropy_hash(0),
- fec_flag(false),
- is_in_fec_group(NOT_IN_FEC_GROUP),
- fec_group(0) {}
+ fec_flag(false) {}
QuicPacketHeader::QuicPacketHeader(const QuicPacketHeader& other) = default;
@@ -288,9 +284,7 @@ ostream& operator<<(ostream& os, const QuicPacketHeader& header) {
<< ", entropy_flag: " << header.entropy_flag
<< ", entropy hash: " << static_cast<int>(header.entropy_hash)
<< ", path_id: " << static_cast<int>(header.path_id)
- << ", packet_number: " << header.packet_number
- << ", is_in_fec_group: " << header.is_in_fec_group
- << ", fec_group: " << header.fec_group << " }\n";
+ << ", packet_number: " << header.packet_number << " }\n";
return os;
}
@@ -311,11 +305,11 @@ QuicStopWaitingFrame::QuicStopWaitingFrame()
QuicStopWaitingFrame::~QuicStopWaitingFrame() {}
QuicAckFrame::QuicAckFrame()
- : path_id(kDefaultPathId),
+ : largest_observed(0),
+ ack_delay_time(QuicTime::Delta::Infinite()),
+ path_id(kDefaultPathId),
entropy_hash(0),
is_truncated(false),
- largest_observed(0),
- ack_delay_time(QuicTime::Delta::Infinite()),
missing(true) {}
QuicAckFrame::QuicAckFrame(const QuicAckFrame& other) = default;
@@ -818,9 +812,9 @@ SerializedPacket::SerializedPacket(QuicPathId path_id,
entropy_hash(entropy_hash),
has_ack(has_ack),
has_stop_waiting(has_stop_waiting),
+ transmission_type(NOT_RETRANSMISSION),
original_path_id(kInvalidPathId),
- original_packet_number(0),
- transmission_type(NOT_RETRANSMISSION) {}
+ original_packet_number(0) {}
SerializedPacket::SerializedPacket(const SerializedPacket& other) = default;
« no previous file with comments | « net/quic/quic_protocol.h ('k') | net/quic/quic_protocol_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698