Match GN and GYP compilation warning flags

Match GN and GYP compilation warning flags

For GN build:
Enable chromium_code compilation config for XFA code;
Remove sign-compare suppression;
Limit the strict-overflow warning suppression only to xfa target;

For GYP build:
Remove warning suppression 4800 from GYP non third-party code;

After this, all the warning flags and levels for GN and GYP
builds should match.
 
BUG=pdfium:29, pdfium:475
Committed: https://pdfium.googlesource.com/pdfium/+/dcc29b1f2eb66984a18d54e66851965472675006

[Wei Li, 2016-05-27 23:00:04]

Description was changed from

==========
Match GN and GYP compilation flags (finally)

For GN build:
Enable chromium_code compilation config;
Remove sign-compare suppression;
Limit the strict-overflow warning suppression only to xfa target;

For GYP build:
Remove warning suppression 4800 from GYP non third-party code;

BUG=pdfium:29, pdfium:475
==========

to

==========
Match GN and GYP compilation flags

For GN build:
Enable chromium_code compilation config for XFA code;
Remove sign-compare suppression;
Limit the strict-overflow warning suppression only to xfa target;

For GYP build:
Remove warning suppression 4800 from GYP non third-party code;

BUG=pdfium:29, pdfium:475
==========

[Wei Li, 2016-05-27 23:27:23]

Description was changed from

==========
Match GN and GYP compilation flags

For GN build:
Enable chromium_code compilation config for XFA code;
Remove sign-compare suppression;
Limit the strict-overflow warning suppression only to xfa target;

For GYP build:
Remove warning suppression 4800 from GYP non third-party code;

BUG=pdfium:29, pdfium:475
==========

to

==========
Match GN and GYP compilation warning flags

For GN build:
Enable chromium_code compilation config for XFA code;
Remove sign-compare suppression;
Limit the strict-overflow warning suppression only to xfa target;

For GYP build:
Remove warning suppression 4800 from GYP non third-party code;

After this, all the warning flags and levels for GN and GYP should match.
 
BUG=pdfium:29, pdfium:475
==========

[Wei Li, 2016-05-27 23:27:55]

Description was changed from

==========
Match GN and GYP compilation warning flags

For GN build:
Enable chromium_code compilation config for XFA code;
Remove sign-compare suppression;
Limit the strict-overflow warning suppression only to xfa target;

For GYP build:
Remove warning suppression 4800 from GYP non third-party code;

After this, all the warning flags and levels for GN and GYP should match.
 
BUG=pdfium:29, pdfium:475
==========

to

==========
Match GN and GYP compilation warning flags

For GN build:
Enable chromium_code compilation config for XFA code;
Remove sign-compare suppression;
Limit the strict-overflow warning suppression only to xfa target;

For GYP build:
Remove warning suppression 4800 from GYP non third-party code;

After this, all the warning flags and levels for GN and GYP
builds should match.
 
BUG=pdfium:29, pdfium:475
==========

[Wei Li, 2016-05-27 23:29:03]

Patchset #1 (id:1) has been deleted

[Wei Li, 2016-05-27 23:46:05]

weili@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[Wei Li, 2016-05-27 23:46:05]

pls review, thanks

[Lei Zhang, 2016-05-27 23:49:21]

lgtm

https://codereview.chromium.org/2011303003/diff/20001/build_gyp/standalone.gypi
File build_gyp/standalone.gypi (left):

https://codereview.chromium.org/2011303003/diff/20001/build_gyp/standalone.gy...
build_gyp/standalone.gypi:205: # This section is PDFium specific.
Can you leave this section here? We still refer to it on line 292.

https://codereview.chromium.org/2011303003/diff/20001/build_gyp/standalone.gy...
build_gyp/standalone.gypi:208: # C4800: forcing value to bool 'true' or 'false'
(performance warning)
Just mention this section is currently empty.

[Tom Sepez, 2016-05-28 00:11:31]

lgtm

[Wei Li, 2016-05-28 00:11:59]

thanks

https://codereview.chromium.org/2011303003/diff/20001/build_gyp/standalone.gypi
File build_gyp/standalone.gypi (left):

https://codereview.chromium.org/2011303003/diff/20001/build_gyp/standalone.gy...
build_gyp/standalone.gypi:205: # This section is PDFium specific.
On 2016/05/27 23:49:20, Lei Zhang wrote:
> Can you leave this section here? We still refer to it on line 292.

sure.

https://codereview.chromium.org/2011303003/diff/20001/build_gyp/standalone.gy...
build_gyp/standalone.gypi:208: # C4800: forcing value to bool 'true' or 'false'
(performance warning)
On 2016/05/27 23:49:20, Lei Zhang wrote:
> Just mention this section is currently empty.

Done.

[Wei Li, 2016-05-28 00:40:38]

The CQ bit was checked by weili@chromium.org

[Wei Li, 2016-05-28 00:40:38]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2011303003/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-05-28 00:40:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2011303003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2011303003/40001

[commit-bot: I haz the power, 2016-05-28 00:58:27]

Description was changed from

==========
Match GN and GYP compilation warning flags

For GN build:
Enable chromium_code compilation config for XFA code;
Remove sign-compare suppression;
Limit the strict-overflow warning suppression only to xfa target;

For GYP build:
Remove warning suppression 4800 from GYP non third-party code;

After this, all the warning flags and levels for GN and GYP
builds should match.
 
BUG=pdfium:29, pdfium:475
==========

to

==========
Match GN and GYP compilation warning flags

For GN build:
Enable chromium_code compilation config for XFA code;
Remove sign-compare suppression;
Limit the strict-overflow warning suppression only to xfa target;

For GYP build:
Remove warning suppression 4800 from GYP non third-party code;

After this, all the warning flags and levels for GN and GYP
builds should match.
 
BUG=pdfium:29, pdfium:475

Committed:
https://pdfium.googlesource.com/pdfium/+/dcc29b1f2eb66984a18d54e6685196547267...
==========

[commit-bot: I haz the power, 2016-05-28 00:58:28]

Committed patchset #2 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/dcc29b1f2eb66984a18d54e6685196547267...