Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: build_gyp/standalone.gypi

Issue 2011303003: Match GN and GYP compilation warning flags (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 PDFium Authors. All rights reserved. 1 # Copyright 2014 PDFium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Definitions to be used when building stand-alone PDFium binaries. 5 # Definitions to be used when building stand-alone PDFium binaries.
6 6
7 { 7 {
8 'variables': { 8 'variables': {
9 'component%': 'static_library', 9 'component%': 'static_library',
10 'chromium_code%': 0, 10 'chromium_code%': 0,
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 'V8_DEPRECATION_WARNINGS', 195 'V8_DEPRECATION_WARNINGS',
196 ], 196 ],
197 'msvs_cygwin_dirs': ['<(DEPTH)/v8/third_party/cygwin'], 197 'msvs_cygwin_dirs': ['<(DEPTH)/v8/third_party/cygwin'],
198 'msvs_configuration_attributes': { 198 'msvs_configuration_attributes': {
199 'OutputDirectory': '<(DEPTH)\\build\\$(ConfigurationName)', 199 'OutputDirectory': '<(DEPTH)\\build\\$(ConfigurationName)',
200 'IntermediateDirectory': '$(OutDir)\\obj\\$(ProjectName)', 200 'IntermediateDirectory': '$(OutDir)\\obj\\$(ProjectName)',
201 'CharacterSet': '1', 201 'CharacterSet': '1',
202 }, 202 },
203 'msvs_disabled_warnings': [ 203 'msvs_disabled_warnings': [
204 # #### 204 # ####
205 # This section is PDFium specific.
Lei Zhang 2016/05/27 23:49:20 Can you leave this section here? We still refer to
Wei Li 2016/05/28 00:11:59 sure.
206 # ####
207
208 # C4800: forcing value to bool 'true' or 'false' (performance warning)
Lei Zhang 2016/05/27 23:49:20 Just mention this section is currently empty.
Wei Li 2016/05/28 00:11:59 Done.
209 4800,
210
211 # ####
212 # This section should match Chromium's build/common.gypi. 205 # This section should match Chromium's build/common.gypi.
213 # #### 206 # ####
214 207
215 # C4091: 'typedef ': ignored on left of 'X' when no variable is 208 # C4091: 'typedef ': ignored on left of 'X' when no variable is
216 # declared. 209 # declared.
217 # This happens in a number of Windows headers. Dumb. 210 # This happens in a number of Windows headers. Dumb.
218 4091, 211 4091,
219 212
220 # C4127: conditional expression is constant 213 # C4127: conditional expression is constant
221 # This warning can in theory catch dead code and other problems, but 214 # This warning can in theory catch dead code and other problems, but
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
472 }], 465 }],
473 ], 466 ],
474 'target_conditions': [ 467 'target_conditions': [
475 ['chromium_code==0', { 468 ['chromium_code==0', {
476 'variables': { 469 'variables': {
477 'clang_warning_flags': [ 470 'clang_warning_flags': [
478 # Suppress unused variable warnings from third-party libraries. 471 # Suppress unused variable warnings from third-party libraries.
479 '-Wno-unused-variable', 472 '-Wno-unused-variable',
480 ], 473 ],
481 }, 474 },
475 'msvs_disabled_warnings': [
476 # forcing value to bool 'true' or 'false' (performance warning)
477 4800,
478 ],
482 'msvs_settings': { 479 'msvs_settings': {
483 'VCCLCompilerTool': { 480 'VCCLCompilerTool': {
484 'WarningLevel': '3', 481 'WarningLevel': '3',
485 }, 482 },
486 }, 483 },
487 'conditions': [ 484 'conditions': [
488 ['OS!="win"', { 485 ['OS!="win"', {
489 # Remove -Wextra for third-party code. 486 # Remove -Wextra for third-party code.
490 'cflags!': [ '-Wextra' ], 487 'cflags!': [ '-Wextra' ],
491 }], 488 }],
(...skipping 38 matching lines...) Expand 10 before | Expand all | Expand 10 after
530 ], 527 ],
531 }], # OS=="win" 528 }], # OS=="win"
532 ["use_goma==1", { 529 ["use_goma==1", {
533 'make_global_settings': [ 530 'make_global_settings': [
534 ['CC_wrapper', '<(gomadir)/gomacc'], 531 ['CC_wrapper', '<(gomadir)/gomacc'],
535 ['CXX_wrapper', '<(gomadir)/gomacc'], 532 ['CXX_wrapper', '<(gomadir)/gomacc'],
536 ], 533 ],
537 }], # use_goma==1 534 }], # use_goma==1
538 ], 535 ],
539 } 536 }
OLDNEW
« no previous file with comments | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698