Index: BUILD.gn |
diff --git a/BUILD.gn b/BUILD.gn |
index 1550209ce14e807c806fc8a4123e7c16ee82d98c..1a8e4f2507735f7eb22b2e06251b61757f79453c 100644 |
--- a/BUILD.gn |
+++ b/BUILD.gn |
@@ -44,14 +44,12 @@ config("pdfium_config") { |
if (is_win) { |
cflags += [ "/wd4267" ] |
} |
+} |
- if (is_clang || is_posix) { |
- # TODO(thestig): Fix all instances, remove this, pdfium:29 |
- cflags += [ "-Wno-sign-compare" ] |
- } |
- |
+config("xfa_warnings") { |
+ visibility = [ ":*" ] |
if (is_posix && !is_clang) { # When GCC. |
- cflags += [ "-Wno-strict-overflow" ] |
+ cflags = [ "-Wno-strict-overflow" ] |
} |
} |
@@ -888,11 +886,7 @@ if (pdf_enable_xfa) { |
deps = [ |
":xfa", |
] |
- configs -= [ "//build/config/compiler:chromium_code" ] |
- configs += [ |
- ":pdfium_config", |
- "//build/config/compiler:no_chromium_code", |
- ] |
+ configs += [ ":pdfium_config" ] |
} |
static_library("xfa") { |
@@ -1593,10 +1587,9 @@ if (pdf_enable_xfa) { |
"//v8:v8_libplatform", |
] |
} |
- configs -= [ "//build/config/compiler:chromium_code" ] |
configs += [ |
":pdfium_config", |
- "//build/config/compiler:no_chromium_code", |
+ ":xfa_warnings", |
] |
} |
} |