Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 2011303002: [arm] [arm64] Add optional operators Float32Neg and Float64Neg. (Closed)

Created:
4 years, 6 months ago by georgia.kouveli
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[arm] [arm64] Add optional operators Float32Neg and Float64Neg. Adding optional operators for FNeg for WebAssembly, as the current implementation was significantly suboptimal for ARM. Committed: https://crrev.com/612bad1d22618def97cee0f0a8abea20468dde8c Cr-Commit-Position: refs/heads/master@{#36544}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+166 lines, -14 lines) Patch
M src/compiler/arm/instruction-selector-arm.cc View 2 chunks +10 lines, -1 line 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-codes-arm64.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/arm64/instruction-scheduler-arm64.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 2 chunks +10 lines, -1 line 0 comments Download
M src/compiler/ia32/instruction-selector-ia32.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 2 chunks +13 lines, -7 lines 0 comments Download
M src/compiler/machine-operator.cc View 1 chunk +3 lines, -1 line 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/s390/instruction-selector-s390.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/wasm-compiler.cc View 1 chunk +16 lines, -4 lines 0 comments Download
M src/compiler/x64/instruction-selector-x64.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M src/compiler/x87/instruction-selector-x87.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M test/cctest/compiler/test-run-machops.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm/instruction-selector-arm-unittest.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +30 lines, -0 lines 0 comments Download
M test/unittests/compiler/machine-operator-unittest.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
georgia.kouveli
4 years, 6 months ago (2016-05-27 10:47:13 UTC) #3
Benedikt Meurer
lgtm
4 years, 6 months ago (2016-05-27 10:48:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2011303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2011303002/1
4 years, 6 months ago (2016-05-27 10:49:22 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-05-27 11:20:41 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 11:22:15 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/612bad1d22618def97cee0f0a8abea20468dde8c
Cr-Commit-Position: refs/heads/master@{#36544}

Powered by Google App Engine
This is Rietveld 408576698