Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2011163004: MediaVideoStreamTrack should store weak reference to the media source. Since MediaVideoStreamSource… (Closed)

Created:
4 years, 6 months ago by miu
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2704
Target Ref:
refs/pending/branch-heads/2704
Project:
chromium
Visibility:
Public.

Description

MediaVideoStreamTrack should store weak reference to the media source. Since MediaVideoStreamSource cann't guarantee to outlive MediaVideoStreamTrack, directly using its raw pointer might cause the incorrect use of MediaVideoStreamSource after it is destructed. BUG=612049 Review-Url: https://codereview.chromium.org/1981113002 Cr-Commit-Position: refs/heads/master@{#394319} (cherry picked from commit 339f60de6b251ae9872fa2c690439aee309b7ea2) Committed: https://chromium.googlesource.com/chromium/src/+/5cfb468a11a4eb74cdab476b9c5b13109117a1a9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M content/renderer/media/media_stream_video_source.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/media/media_stream_video_track.h View 1 chunk +2 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_video_track.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
miu
4 years, 6 months ago (2016-05-27 21:12:04 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
5cfb468a11a4eb74cdab476b9c5b13109117a1a9.

Powered by Google App Engine
This is Rietveld 408576698