Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2021)

Unified Diff: content/renderer/media/media_stream_video_track.h

Issue 2011163004: MediaVideoStreamTrack should store weak reference to the media source. Since MediaVideoStreamSource… (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@2704
Patch Set: Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/media/media_stream_video_track.h
diff --git a/content/renderer/media/media_stream_video_track.h b/content/renderer/media/media_stream_video_track.h
index 9769d3bb7f13f3749fa11f354917da9596a7dbc4..3184e3c2de6e2093e1fc3249b0ee64683a9b5e9b 100644
--- a/content/renderer/media/media_stream_video_track.h
+++ b/content/renderer/media/media_stream_video_track.h
@@ -84,10 +84,8 @@ class CONTENT_EXPORT MediaStreamVideoTrack : public MediaStreamTrack {
const blink::WebMediaConstraints constraints_;
- // Weak ref to the source this tracks is connected to. |source_| is owned
- // by the blink::WebMediaStreamSource and is guaranteed to outlive the
- // track.
- MediaStreamVideoSource* source_;
+ // Weak ref to the source this tracks is connected to.
+ base::WeakPtr<MediaStreamVideoSource> source_;
DISALLOW_COPY_AND_ASSIGN(MediaStreamVideoTrack);
};
« no previous file with comments | « content/renderer/media/media_stream_video_source.h ('k') | content/renderer/media/media_stream_video_track.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698