Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(630)

Issue 1981113002: MediaVideoStreamTrack should store weak reference to the media source. (Closed)

Created:
4 years, 7 months ago by xjz
Modified:
4 years, 7 months ago
Reviewers:
miu
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, posciak+watch_chromium.org, jam, feature-media-reviews_chromium.org, darin-cc_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-renderer_chromium.org, miu+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MediaVideoStreamTrack should store weak reference to the media source. Since MediaVideoStreamSource cann't guarantee to outlive MediaVideoStreamTrack, directly using its raw pointer might cause the incorrect use of MediaVideoStreamSource after it is destructed. BUG=612049 Committed: https://crrev.com/339f60de6b251ae9872fa2c690439aee309b7ea2 Cr-Commit-Position: refs/heads/master@{#394319}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M content/renderer/media/media_stream_video_source.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/renderer/media/media_stream_video_track.h View 1 chunk +2 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_video_track.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
xjz
PTAL
4 years, 7 months ago (2016-05-16 23:29:59 UTC) #2
miu
lgtm
4 years, 7 months ago (2016-05-17 21:46:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981113002/1
4 years, 7 months ago (2016-05-17 21:47:35 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/205188)
4 years, 7 months ago (2016-05-17 23:49:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1981113002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1981113002/1
4 years, 7 months ago (2016-05-17 23:57:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-18 03:17:52 UTC) #10
commit-bot: I haz the power
4 years, 7 months ago (2016-05-18 03:20:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/339f60de6b251ae9872fa2c690439aee309b7ea2
Cr-Commit-Position: refs/heads/master@{#394319}

Powered by Google App Engine
This is Rietveld 408576698