Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issue 2010823002: Remove assorted unnecessary includes in core/paint/ (Closed)

Created:
4 years, 7 months ago by mstensho (USE GERRIT)
Modified:
4 years, 7 months ago
Reviewers:
chrishtr, eae
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove assorted unnecessary includes in core/paint/ I was mainly looking at inclusions of LayoutObject-derived header files, but removed some others as well, while I was at it. BUG=614015 TBR=chrishtr@chromium.org,eae@chromium.org Committed: https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871 Cr-Commit-Position: refs/heads/master@{#396037}

Patch Set 1 #

Patch Set 2 : Missing includes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -43 lines) Patch
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxBorderPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxPainter.h View 1 chunk +12 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FilterEffectBuilder.cpp View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/InlineFlowBoxPainter.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlinePainter.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/LineBoxListPainter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ListMarkerPainter.cpp View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/MultiColumnSetPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayer.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.h View 1 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerReflectionInfo.h View 1 chunk +4 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerScrollableArea.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PartPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/RoundedInnerRectClipper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGImagePainter.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/SVGInlineFlowBoxPainter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/ScopeRecorder.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/TableCellPainter.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableRowPainter.h View 1 chunk +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableRowPainter.cpp View 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/TableSectionPainter.cpp View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
mstensho (USE GERRIT)
4 years, 7 months ago (2016-05-25 21:28:55 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2010823002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2010823002/20001
4 years, 7 months ago (2016-05-25 21:30:03 UTC) #7
chrishtr
lgtm
4 years, 7 months ago (2016-05-25 22:16:36 UTC) #8
eae
LGTM
4 years, 7 months ago (2016-05-25 22:19:48 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-25 23:28:48 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-25 23:30:19 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c66aa2dac45fbecf3590d661cf4133781951d871
Cr-Commit-Position: refs/heads/master@{#396037}

Powered by Google App Engine
This is Rietveld 408576698