services/media/factory_service/factory_service.h - Issue 2010283006: Almost done: ApplicationDelegate -> ApplicationImplBase conversion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/media/factory_service/factory_service.h

Issue 2010283006: Almost done: ApplicationDelegate -> ApplicationImplBase conversion. (Closed) Base URL: https://github.com/domokit/mojo.git@work798-x-work797-x-work796_no_run_main_app

Patch Set: rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: services/media/factory_service/factory_service.h

diff --git a/services/media/factory_service/factory_service.h b/services/media/factory_service/factory_service.h

index c87e2715dfe6e47176cafa2d1ae9bda85d6422bd..0955092f4240903e77b24ce04732aa8e0ecbfdaf 100644

--- a/services/media/factory_service/factory_service.h

+++ b/services/media/factory_service/factory_service.h

@@ -6,8 +6,6 @@

#define MOJO_SERVICES_MEDIA_FACTORY_FACTORY_SERVICE_H_

#include "mojo/common/binding_set.h"

-#include "mojo/public/cpp/application/application_delegate.h"

-#include "mojo/public/cpp/application/application_impl.h"

#include "mojo/services/media/control/interfaces/media_factory.mojom.h"

#include "services/util/cpp/factory_service_base.h"

@@ -21,9 +19,8 @@ class MediaFactoryService : public util::FactoryServiceBase,

~MediaFactoryService() override;

- // ApplicationDelegate implementation.

- bool ConfigureIncomingConnection(

- ServiceProviderImpl* service_provider_impl) override;

+ // ApplicationImplBase override.

+ bool OnAcceptConnection(ServiceProviderImpl* service_provider_impl) override;

// MediaFactory implementation.

void CreatePlayer(InterfaceHandle<SeekingReader> reader,

« no previous file with comments | « services/media/factory_service/audio_track_controller.cc ('k') | services/media/factory_service/factory_service.cc » ('j') | no next file with comments »