services/media/factory_service/factory_service.cc - Issue 2010283006: Almost done: ApplicationDelegate -> ApplicationImplBase conversion.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/media/factory_service/factory_service.cc

Issue 2010283006: Almost done: ApplicationDelegate -> ApplicationImplBase conversion. (Closed) Base URL: https://github.com/domokit/mojo.git@work798-x-work797-x-work796_no_run_main_app

Patch Set: rebased Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: services/media/factory_service/factory_service.cc

diff --git a/services/media/factory_service/factory_service.cc b/services/media/factory_service/factory_service.cc

index 5d87ad4723954c760d948ebfc4839870281edd0e..d99d53e5d7c7258077db6254e9ef84520c35fd5d 100644

--- a/services/media/factory_service/factory_service.cc

+++ b/services/media/factory_service/factory_service.cc

@@ -3,6 +3,8 @@

// found in the LICENSE file.

#include "services/media/factory_service/factory_service.h"

+#include "mojo/public/cpp/application/service_provider_impl.h"

#include "services/media/factory_service/media_decoder_impl.h"

#include "services/media/factory_service/media_demux_impl.h"

#include "services/media/factory_service/media_player_impl.h"

@@ -18,7 +20,7 @@ MediaFactoryService::MediaFactoryService() {}

MediaFactoryService::~MediaFactoryService() {}

-bool MediaFactoryService::ConfigureIncomingConnection(

+bool MediaFactoryService::OnAcceptConnection(

ServiceProviderImpl* service_provider_impl) {

service_provider_impl->AddService<MediaFactory>(

[this](const ConnectionContext& connection_context,

« no previous file with comments | « services/media/factory_service/factory_service.h ('k') | services/media/factory_service/main.cc » ('j') | no next file with comments »