Enable pylint warnings on presubmit checks.

Enable pylint warnings on presubmit checks.

In http://crbug.com/493941, it was mentioned that we could fix all current pylint warnings before enabling pylint warnings in the presubmit -- but actually we could also enable warnings in the presubmit now without causing any problems; pylint will only print warnings about lines that are changed in a CL, and turning on warnings now could be potentially helpful in cleaning up the code.

And turning on pylint warnings in check-webkit-style and the presubmit is just a one line change; any reason not to just do it now?

NOPRESUBMIT=true
BUG=493941
Committed: https://crrev.com/d198da47ae0b4952bdfb3f15640bf1071cd86e3f
Cr-Commit-Position: refs/heads/master@{#397780}

[qyearsley, 2016-05-27 00:00:13]

Description was changed from

==========
Enable pylint warnings on presubmit checks.

BUG=493941
==========

to

==========
Enable pylint warnings on presubmit checks.

In http://crbug.com/493941, it was mentioned that we could fix all current
pylint warnings before enabling pylint warnings in the presubmit -- but actually
we could also enable warnings in the presubmit now without causing any problems;
pylint will only print warnings about lines that are changed in a CL, and
turning on warnings now could be potentially helpful in cleaning up the code.

And turning on pylint warnings in check-webkit-style and the presubmit is just a
one line change; any reason not to just do it now?

BUG=493941
==========

[qyearsley, 2016-05-27 00:00:13]

qyearsley@chromium.org changed reviewers:
+ jsbell@chromium.org

[qyearsley, 2016-05-27 15:56:55]

qyearsley@chromium.org changed reviewers:
+ tansell@chromium.org

[qyearsley, 2016-05-28 16:39:17]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-28 16:39:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2010173003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2010173003/1

[commit-bot: I haz the power, 2016-05-28 17:43:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-28 17:43:57]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[qyearsley, 2016-05-28 19:39:05]

Description was changed from

==========
Enable pylint warnings on presubmit checks.

In http://crbug.com/493941, it was mentioned that we could fix all current
pylint warnings before enabling pylint warnings in the presubmit -- but actually
we could also enable warnings in the presubmit now without causing any problems;
pylint will only print warnings about lines that are changed in a CL, and
turning on warnings now could be potentially helpful in cleaning up the code.

And turning on pylint warnings in check-webkit-style and the presubmit is just a
one line change; any reason not to just do it now?

BUG=493941
==========

to

==========
Enable pylint warnings on presubmit checks.

In http://crbug.com/493941, it was mentioned that we could fix all current
pylint warnings before enabling pylint warnings in the presubmit -- but actually
we could also enable warnings in the presubmit now without causing any problems;
pylint will only print warnings about lines that are changed in a CL, and
turning on warnings now could be potentially helpful in cleaning up the code.

And turning on pylint warnings in check-webkit-style and the presubmit is just a
one line change; any reason not to just do it now?

NOPRESUBMIT=true
BUG=493941
==========

[qyearsley, 2016-05-28 19:39:25]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-28 19:39:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2010173003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2010173003/20001

[qyearsley, 2016-05-29 21:00:33]

https://codereview.chromium.org/2010173003/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/pylintrc (right):

https://codereview.chromium.org/2010173003/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/pylintrc:61: print-statement,
Pylint prints errors about print statements if --errors-only is passed, or if
the print-statement check is explicitly enabled.

i.e., when --errors-only flag is given, errors about print statements are shown
even if that type of error is not enabled normally. This might be a bug in
pylint.

https://codereview.chromium.org/2010173003/diff/20001/third_party/WebKit/Tool...
File third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python_unittest.py
(right):

https://codereview.chromium.org/2010173003/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python_unittest.py:68:
(2, 'pylint/C0303(trailing-whitespace)', 5, '[] Trailing whitespace'),
Note that pylint and pep8 both print warnings about trailing whitespace; this is
redundant but not a problem.

https://codereview.chromium.org/2010173003/diff/20001/third_party/WebKit/Tool...
third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python_unittest.py:71:
(3, 'pylint/W0611(unused-import)', 5, '[] Unused import math'),
After this CL, warnings about unused imports etc. should also be shown by this
python checker.

[mithro, 2016-06-01 01:30:22]

I like the idea. If you are certain this works as described, then LGTM.

[qyearsley, 2016-06-01 17:11:51]

qyearsley@chromium.org changed reviewers:
+ dpranke@chromium.org

[qyearsley, 2016-06-01 17:13:03]

qyearsley@chromium.org changed reviewers:
- dpranke@chromium.org

[qyearsley, 2016-06-01 17:13:29]

On 2016/06/01 at 01:30:22, tansell wrote:
> I like the idea. If you are certain this works as described, then LGTM.

Alright -- note, the effect of this CL should be to increase the number of
warnings that presubmit will give you, but only for lines that are changed in
your CL.

Dirk or Ojan, any comments/suggestions? Otherwise I'll commit this today.

[Dirk Pranke, 2016-06-01 17:23:37]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2016-06-01 17:23:38]

lgtm.

[qyearsley, 2016-06-03 17:31:11]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-06-03 17:32:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2010173003/40001

[qyearsley, 2016-06-03 18:28:17]

The CQ bit was unchecked by qyearsley@chromium.org

[qyearsley, 2016-06-03 18:28:21]

The CQ bit was checked by qyearsley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-03 18:28:53]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2010173003/40001

[commit-bot: I haz the power, 2016-06-03 18:40:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-03 18:40:14]

Dry run: This issue passed the CQ dry run.

[qyearsley, 2016-06-03 19:46:41]

The CQ bit was checked by qyearsley@chromium.org

[commit-bot: I haz the power, 2016-06-03 19:47:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2010173003/40001

[commit-bot: I haz the power, 2016-06-03 19:48:39]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-03 19:49:34]

Description was changed from

==========
Enable pylint warnings on presubmit checks.

In http://crbug.com/493941, it was mentioned that we could fix all current
pylint warnings before enabling pylint warnings in the presubmit -- but actually
we could also enable warnings in the presubmit now without causing any problems;
pylint will only print warnings about lines that are changed in a CL, and
turning on warnings now could be potentially helpful in cleaning up the code.

And turning on pylint warnings in check-webkit-style and the presubmit is just a
one line change; any reason not to just do it now?

NOPRESUBMIT=true
BUG=493941
==========

to

==========
Enable pylint warnings on presubmit checks.

In http://crbug.com/493941, it was mentioned that we could fix all current
pylint warnings before enabling pylint warnings in the presubmit -- but actually
we could also enable warnings in the presubmit now without causing any problems;
pylint will only print warnings about lines that are changed in a CL, and
turning on warnings now could be potentially helpful in cleaning up the code.

And turning on pylint warnings in check-webkit-style and the presubmit is just a
one line change; any reason not to just do it now?

NOPRESUBMIT=true
BUG=493941

Committed: https://crrev.com/d198da47ae0b4952bdfb3f15640bf1071cd86e3f
Cr-Commit-Position: refs/heads/master@{#397780}
==========

[commit-bot: I haz the power, 2016-06-03 19:49:35]

Patchset 3 (id:??) landed as
https://crrev.com/d198da47ae0b4952bdfb3f15640bf1071cd86e3f
Cr-Commit-Position: refs/heads/master@{#397780}