Enable pylint warnings on presubmit checks.

third_party/WebKit/Tools/Scripts/webkitpy/style/checkers/python.py

 # Copyright (C) 2010 Chris Jerdonek (cjerdonek@webkit.org)
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions
 # are met:
 # 1.  Redistributions of source code must retain the above copyright
 #     notice, this list of conditions and the following disclaimer.
 # 2.  Redistributions in binary form must reproduce the above copyright
 #     notice, this list of conditions and the following disclaimer in the
 #     documentation and/or other materials provided with the distribution.
@@ skipping 22 matching lines @@
 from webkitpy.thirdparty import pep8
 
 
 class PythonChecker(object):
     """Processes text lines for checking style."""
 
     def __init__(self, file_path, handle_style_error):
         self._file_path = file_path
         self._handle_style_error = handle_style_error
 
-    def check(self, lines):
-        self._check_pep8(lines)
-        self._check_pylint(lines)
+    def check(self, lines_unused=None):
+        self._check_pep8()
+        self._check_pylint()
 
-    def _check_pep8(self, lines):
+    def _check_pep8(self):
         # Initialize pep8.options, which is necessary for
         # Checker.check_all() to execute.
         pep8.process_options(arglist=[self._file_path])
 
         pep8_checker = pep8.Checker(self._file_path)
 
         def _pep8_handle_error(line_number, offset, text, check):
             # FIXME: Incorporate the character offset into the error output.
             #        This will require updating the error handler __call__
             #        signature to include an optional "offset" parameter.
             pep8_code = text[:4]
             pep8_message = text[5:]
 
             category = "pep8/" + pep8_code
 
             self._handle_style_error(line_number, category, 5, pep8_message)
 
         pep8_checker.report_error = _pep8_handle_error
         pep8_errors = pep8_checker.check_all()
 
-    def _check_pylint(self, lines):
+    def _check_pylint(self):
         output = self._run_pylint(self._file_path)
+        print output
         errors = self._parse_pylint_output(output)
         for line_number, category, message in errors:
             self._handle_style_error(line_number, category, 5, message)
 
     def _run_pylint(self, path):
         wkf = WebKitFinder(FileSystem())
         executive = Executive()
         env = os.environ.copy()
         env['PYTHONPATH'] = ('%s%s%s%s%s' % (wkf.path_from_webkit_base('Tools', 'Scripts'),
                                              os.pathsep,
                                              wkf.path_from_webkit_base('Source', 'build', 'scripts'),
                                              os.pathsep,
                                              wkf.path_from_webkit_base('Tools', 'Scripts', 'webkitpy', 'thirdparty')))
         return executive.run_command([sys.executable, wkf.path_from_depot_tools_base('pylint.py'),
                                       '--output-format=parseable',
-                                      '--errors-only',
                                       '--rcfile=' + wkf.path_from_webkit_base('Tools', 'Scripts', 'webkitpy', 'pylintrc'),
                                       path],
                                      env=env,
                                      error_handler=executive.ignore_error)
 
     def _parse_pylint_output(self, output):
         # We filter out these messages because they are bugs in pylint that produce false positives.
         # FIXME: Does it make sense to combine these rules with the rules in style/checker.py somehow?
         FALSE_POSITIVES = [
             # possibly http://www.logilab.org/ticket/98613 ?
@@ skipping 17 matching lines @@
 
             line_number = int(match_obj.group(2))
             category_and_method = match_obj.group(3).split(', ')
             category = 'pylint/' + (category_and_method[0])
             if len(category_and_method) > 1:
                 message = '[%s] %s' % (category_and_method[1], match_obj.group(4))
             else:
                 message = match_obj.group(4)
             errors.append((line_number, category, message))
         return errors