Issue 20101004: Added GM to test forthcoming bleed flag

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20101004: Added GM to test forthcoming bleed flag (Closed)

Created:
7 years, 5 months ago by robertphillips

Modified:
7 years, 5 months ago

Reviewers:
bsalomon

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Patch Set 4 : added usage of setMaxTextureSizeOverride #

Patch Set 6 : Fixed function name #

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+171 lines, -0 lines)			Patch
	A	gm/bleed.cpp	View	1 2 3 4 5	1 chunk	+170 lines, -0 lines	0 comments	Download
	M	gyp/gmslides.gypi	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

bsalomon

lgtm https://codereview.chromium.org/20101004/diff/13001/gm/bleed.cpp File gm/bleed.cpp (right): https://codereview.chromium.org/20101004/diff/13001/gm/bleed.cpp#newcode25 gm/bleed.cpp:25: static void make_white_ringed_bitmap(SkBitmap* result, int width, int height) ...

7 years, 5 months ago (2013-07-25 19:08:21 UTC) #3

robertphillips

https://codereview.chromium.org/20101004/diff/13001/gm/bleed.cpp File gm/bleed.cpp (right): https://codereview.chromium.org/20101004/diff/13001/gm/bleed.cpp#newcode25 gm/bleed.cpp:25: static void make_white_ringed_bitmap(SkBitmap* result, int width, int height) { ...

7 years, 5 months ago (2013-07-25 19:29:33 UTC) #4

Message was sent while issue was closed.

committed as r10375

Expand Messages | Collapse Messages

Issue 20101004: Added GM to test forthcoming bleed flag (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix bugs #

Patch Set 3 : Fixed bugs #

Patch Set 4 : added usage of setMaxTextureSizeOverride #

Patch Set 5 : update to ToT #

Patch Set 6 : Fixed function name #

Messages