bluetooth: Make public BluetoothDevice::GetName method.

bluetooth: Make public BluetoothDevice::GetName method.

This change prepares for http://crrev.com/2014473002
which will allow Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.

GetDeviceName is moved from a protected method to a public method
GetNameOrEmpty.

http://crrev.com/2017393002 GetName -> GetNameForDisplay
http://crrev.com/2009753002 New GetName <<< This change.
http://crrev.com/2014473002 Web Bluetooth updated
http://crrev.com/2020923002 Arc Bridge updated

BUG=615720
Committed: https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7
Cr-Commit-Position: refs/heads/master@{#406790}

[scheib, 2016-05-25 03:45:38]

Description was changed from

==========
bluetooth: Make a public BluetoothDevice::GetNameOrEmpty method.

This change prepars for ____________________________________
which will allow Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.

GetDeviceName is moved from a protected method to a public method
GetNameOrEmpty.

BUG=586438
==========

to

==========
bluetooth: Make a public BluetoothDevice::GetNameOrEmpty method.

This change prepars for http://crrev.com/2014473002
which will allow Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.

GetDeviceName is moved from a protected method to a public method
GetNameOrEmpty.

BUG=586438
==========

[scheib, 2016-05-25 03:47:09]

Description was changed from

==========
bluetooth: Make a public BluetoothDevice::GetNameOrEmpty method.

This change prepars for http://crrev.com/2014473002
which will allow Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.

GetDeviceName is moved from a protected method to a public method
GetNameOrEmpty.

BUG=586438
==========

to

==========
bluetooth: Make a public BluetoothDevice::GetNameOrEmpty method.

This change prepares for http://crrev.com/2014473002
which will allow Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.

GetDeviceName is moved from a protected method to a public method
GetNameOrEmpty.

BUG=586438
==========

[scheib, 2016-05-25 03:47:21]

scheib@chromium.org changed reviewers:
+ ortuno@chromium.org

[ortuno, 2016-05-25 16:55:14]

What do you think of returning an Optional? That way users of this method can
just use the result itself for the conditional:

Optional<std::string> name = device.GetName();

if (name)
  ShowName(name.value);

[scheib, 2016-05-25 18:04:27]

On 2016/05/25 16:55:14, ortuno wrote:
> What do you think of returning an Optional? That way users of this method can
> just use the result itself for the conditional:
> 
> Optional<std::string> name = device.GetName();
> 
> if (name)
>   ShowName(name.value);

I think most consumers want some name that they can use no matter what, e.g. for
UI, Logging, chrome APIs, in which case they want the previous behavior of
GetName. So, I don't want to remove that, and don't want to change it to an
optional.

For clients that care about only the actual name on the device, I think we could
do as in this patch (my preference), or we could have a boolean such as
device.HasName(), or device.GetNameWillBeGenerated().

[ortuno, 2016-05-25 19:27:47]

On 2016/05/25 at 18:04:27, scheib wrote:
> On 2016/05/25 16:55:14, ortuno wrote:
> > What do you think of returning an Optional? That way users of this method
can
> > just use the result itself for the conditional:
> > 
> > Optional<std::string> name = device.GetName();
> > 
> > if (name)
> >   ShowName(name.value);
> 
> I think most consumers want some name that they can use no matter what, e.g.
for UI, Logging, chrome APIs, in which case they want the previous behavior of
GetName. So, I don't want to remove that, and don't want to change it to an
optional.
> 

Ah sorry my example code is wrong. I didn't mean to imply that we should change
GetName to return an optional, but rather we should introduce a new function
that returns an optional. But now that you mention it a hasName function would
be better; see below.

> For clients that care about only the actual name on the device, I think we
could do as in this patch (my preference), or we could have a boolean such as
device.HasName(), or device.GetNameWillBeGenerated().

I think the hasName() pattern works better. There are two places in our code
that will use the new function: filtering and device creation. I think for both
cases using the hasName function works better:

Filtering:
bool MatchesFilter(const device::BluetoothDevice& device,
                   const content::BluetoothScanFilter& filter) {
...
  if (!filter.namePrefix.empty()) {
    if (!device.hasName())
      return false;
    if (!base::StartsWith(device_name, filter.namePrefix,
                          base::CompareCase::SENSITIVE))
      return false;
  }

  if (!filter.name.empty()) {
    if (!device.hasName())
      return false;
    if (device_name != filter.name)
      return false;
  }

...
}

Device Creation:

content::BluetoothDevice device_ipc(
      device_id_for_origin,  // id
      device->hasName() ? device->GetName() : std::string(),     // name
      content::BluetoothDevice::UUIDsFromBluetoothUUIDs(
          filtered_uuids));  // uuids

WDYT?

[scheib, 2016-05-29 17:51:13]

Description was changed from

==========
bluetooth: Make a public BluetoothDevice::GetNameOrEmpty method.

This change prepares for http://crrev.com/2014473002
which will allow Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.

GetDeviceName is moved from a protected method to a public method
GetNameOrEmpty.

BUG=586438
==========

to

==========
bluetooth: Make a public BluetoothDevice::GetNameOrEmpty method.

This change prepares for http://crrev.com/2014473002
which will allow Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.

GetDeviceName is moved from a protected method to a public method
GetNameOrEmpty.

BUG=615720
==========

[scheib, 2016-05-29 20:37:36]

Description was changed from

==========
bluetooth: Make a public BluetoothDevice::GetNameOrEmpty method.

This change prepares for http://crrev.com/2014473002
which will allow Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.

GetDeviceName is moved from a protected method to a public method
GetNameOrEmpty.

BUG=615720
==========

to

==========
bluetooth: Make a public BluetoothDevice::GetNameOrEmpty method.

This change prepares for http://crrev.com/2014473002
which will allow Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.

GetDeviceName is moved from a protected method to a public method
GetNameOrEmpty.

http://crrev.com/2017393002 GetName -> GetNameForDisplay
http://crrev.com/2009753002 New GetName <<< This change.
http://crrev.com/2014473002 Web Bluetooth updated
http://crrev.com/2020923002 Arc Bridge updated

BUG=615720
==========

[scheib, 2016-07-12 02:24:51]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 02:25:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 02:51:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 02:51:55]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[scheib, 2016-07-12 20:41:39]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 20:43:00]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2016-07-12 20:47:21]

Patchset #3 (id:40001) has been deleted

[commit-bot: I haz the power, 2016-07-12 21:23:25]

The CQ bit was unchecked by commit-bot@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-12 21:23:26]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[scheib, 2016-07-14 18:53:30]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 18:54:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 18:58:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 18:58:04]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[scheib, 2016-07-14 20:35:04]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-14 20:35:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2016-07-14 20:42:22]

After in person discussion, using a return of base::Optional from GetName.

[commit-bot: I haz the power, 2016-07-14 21:11:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 21:11:25]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[ortuno, 2016-07-14 21:11:41]

lgtm, but consider using make_optional and nullopt instead.

https://codereview.chromium.org/2009753002/diff/100001/device/bluetooth/andro...
File
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java
(right):

https://codereview.chromium.org/2009753002/diff/100001/device/bluetooth/andro...
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java:110:
return mDevice.getName();
nit optional: hmm I wonder if we should explicitly check for null to make it
obvious that getName could return null?

https://codereview.chromium.org/2009753002/diff/100001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_classic_device_mac.mm (right):

https://codereview.chromium.org/2009753002/diff/100001/device/bluetooth/bluet...
device/bluetooth/bluetooth_classic_device_mac.mm:112: return
base::Optional<std::string>();
any reason why you don't use base::make_optional and base::nullopt?

https://codereview.chromium.org/2009753002/diff/100001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_low_energy_win.cc (left):

https://codereview.chromium.org/2009753002/diff/100001/device/bluetooth/bluet...
device/bluetooth/bluetooth_low_energy_win.cc:474: if
(device_interface_data->InterfaceClassGuid !=
Hmm this would mean that we no longer fail if we can't get the device's name
which I guess is OK, but I wish we knew if we are always expected to be able to
get a name...

[scheib, 2016-07-15 20:17:01]

Description was changed from

==========
bluetooth: Make a public BluetoothDevice::GetNameOrEmpty method.

This change prepares for http://crrev.com/2014473002
which will allow Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.

GetDeviceName is moved from a protected method to a public method
GetNameOrEmpty.

http://crrev.com/2017393002 GetName -> GetNameForDisplay
http://crrev.com/2009753002 New GetName <<< This change.
http://crrev.com/2014473002 Web Bluetooth updated
http://crrev.com/2020923002 Arc Bridge updated

BUG=615720
==========

to

==========
bluetooth: Make public BluetoothDevice::GetName method.

This change prepares for http://crrev.com/2014473002
which will allow Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.

GetDeviceName is moved from a protected method to a public method
GetNameOrEmpty.

http://crrev.com/2017393002 GetName -> GetNameForDisplay
http://crrev.com/2009753002 New GetName <<< This change.
http://crrev.com/2014473002 Web Bluetooth updated
http://crrev.com/2020923002 Arc Bridge updated

BUG=615720
==========

[scheib, 2016-07-16 00:20:16]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-16 00:20:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2016-07-16 00:21:36]

Thanks, reilly would you PTAL at 
  extensions/browser/api/bluetooth/bluetooth_apitest.cc

https://codereview.chromium.org/2009753002/diff/100001/device/bluetooth/andro...
File
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java
(right):

https://codereview.chromium.org/2009753002/diff/100001/device/bluetooth/andro...
device/bluetooth/android/java/src/org/chromium/device/bluetooth/ChromeBluetoothDevice.java:110:
return mDevice.getName();
On 2016/07/14 21:11:41, ortuno wrote:
> nit optional: hmm I wonder if we should explicitly check for null to make it
> obvious that getName could return null?

I think no, getName is documented, and I don't think adding more code here helps
much.

https://codereview.chromium.org/2009753002/diff/100001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_classic_device_mac.mm (right):

https://codereview.chromium.org/2009753002/diff/100001/device/bluetooth/bluet...
device/bluetooth/bluetooth_classic_device_mac.mm:112: return
base::Optional<std::string>();
On 2016/07/14 21:11:41, ortuno wrote:
> any reason why you don't use base::make_optional and base::nullopt?

Done.

https://codereview.chromium.org/2009753002/diff/100001/device/bluetooth/bluet...
File device/bluetooth/bluetooth_low_energy_win.cc (left):

https://codereview.chromium.org/2009753002/diff/100001/device/bluetooth/bluet...
device/bluetooth/bluetooth_low_energy_win.cc:474: if
(device_interface_data->InterfaceClassGuid !=
On 2016/07/14 21:11:41, ortuno wrote:
> Hmm this would mean that we no longer fail if we can't get the device's name
> which I guess is OK, but I wish we knew if we are always expected to be able
to
> get a name...

Acknowledged, would be great to know if we'd always get one or not. But since we
can tolerate not receiving one I don't see a need for the awkward old check.

[scheib, 2016-07-16 00:22:16]

scheib@chromium.org changed reviewers:
+ reillyg@chromium.org

[scheib, 2016-07-16 00:22:17]

reillyg would you PTAL at 
  extensions/browser/api/bluetooth/bluetooth_apitest.cc

[Reilly Grant (use Gerrit), 2016-07-16 00:26:06]

lgtm though I agree make_optional would be nice.

[commit-bot: I haz the power, 2016-07-16 00:56:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 00:56:10]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scheib, 2016-07-16 01:20:43]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-16 01:20:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-16 02:02:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-16 02:02:42]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scheib, 2016-07-17 22:08:34]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-17 22:08:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2016-07-17 22:10:03]

Patchset #7 (id:140001) has been deleted

[scheib, 2016-07-17 22:12:22]

scheib@chromium.org changed reviewers:
+ stevenjb@chromium.org

[scheib, 2016-07-17 22:12:23]

stevenjb, OWNERS for dbus/property.h please. This simplifies test code to be
able to set a property value and not have to also then set it as is_valid.

[commit-bot: I haz the power, 2016-07-17 22:44:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-17 22:44:48]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scheib, 2016-07-18 04:54:12]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 04:54:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2016-07-18 05:08:52]

Note, I've noticed a snag on Bluez --- I will need to follow up with additional
work to handle 'alias' and 'name' differently.

[commit-bot: I haz the power, 2016-07-18 05:56:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 05:56:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[stevenjb, 2016-07-18 15:35:32]

stevenjb@chromium.org changed reviewers:
+ hashimoto@chromium.org

[stevenjb, 2016-07-18 15:35:33]

hashimoto@, can you take a look at the change to dbus/property.h ?

https://codereview.chromium.org/2009753002/diff/180001/dbus/property.h
File dbus/property.h (right):

https://codereview.chromium.org/2009753002/diff/180001/dbus/property.h#newcod...
dbus/property.h:437: set_valid(true);
+hashimoto@ for a better owner. I think that we should probably make this change
separately and make sure it is tested.

[hashimoto, 2016-07-19 07:56:19]

https://codereview.chromium.org/2009753002/diff/180001/dbus/property.h
File dbus/property.h (right):

https://codereview.chromium.org/2009753002/diff/180001/dbus/property.h#newcod...
dbus/property.h:437: set_valid(true);
On 2016/07/18 15:35:32, stevenjb wrote:
> +hashimoto@ for a better owner. I think that we should probably make this
change
> separately and make sure it is tested.

To be honest I'm also unfamiliar with this code. (IIUC, unfortunately, no one
actively working on Chromium is familiar with this dbus::Property code)
It'd be appreciated if you could make this change separately as suggested by
Steven.

[stevenjb, 2016-07-19 16:00:49]

Yeah, sorry to make you jump through hoops, but since we don't have a lot
of expertise here let's make this change separately and add at least some
sort of a test. Include myself, hashimot@, and derat@ on the review. Thanks!


On Tue, Jul 19, 2016 at 12:56 AM, <hashimoto@chromium.org> wrote:

>
> https://codereview.chromium.org/2009753002/diff/180001/dbus/property.h
> File dbus/property.h (right):
>
>
>
https://codereview.chromium.org/2009753002/diff/180001/dbus/property.h#newcod...
> dbus/property.h:437: set_valid(true);
> On 2016/07/18 15:35:32, stevenjb wrote:
> > +hashimoto@ for a better owner. I think that we should probably make
> this change
> > separately and make sure it is tested.
>
> To be honest I'm also unfamiliar with this code. (IIUC, unfortunately,
> no one actively working on Chromium is familiar with this dbus::Property
> code)
> It'd be appreciated if you could make this change separately as
> suggested by Steven.
>
> https://codereview.chromium.org/2009753002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[scheib, 2016-07-20 21:38:41]

Patchset #7 (id:160001) has been deleted

[scheib, 2016-07-20 21:39:11]

Patchset #7 (id:180001) has been deleted

[scheib, 2016-07-20 21:40:30]

Patchset #7 (id:200001) has been deleted

[scheib, 2016-07-20 21:43:38]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 21:44:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 23:04:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 23:04:51]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scheib, 2016-07-21 00:51:27]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 00:51:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2016-07-21 00:57:50]

Patchset #9 (id:260001) has been deleted

[scheib, 2016-07-21 00:57:54]

The CQ bit was checked by scheib@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-21 00:58:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scheib, 2016-07-21 01:00:09]

On 2016/07/19 16:00:49, stevenjb wrote:
> Yeah, sorry to make you jump through hoops, but since we don't have a lot
> of expertise here let's make this change separately and add at least some
> sort of a test. Include myself, hashimot@, and derat@ on the review. Thanks!
> 
> 
> On Tue, Jul 19, 2016 at 12:56 AM, <mailto:hashimoto@chromium.org> wrote:
> 
> >
> > https://codereview.chromium.org/2009753002/diff/180001/dbus/property.h
> > File dbus/property.h (right):
> >
> >
> >
>
https://codereview.chromium.org/2009753002/diff/180001/dbus/property.h#newcod...
> > dbus/property.h:437: set_valid(true);
> > On 2016/07/18 15:35:32, stevenjb wrote:
> > > +hashimoto@ for a better owner. I think that we should probably make
> > this change
> > > separately and make sure it is tested.
> >
> > To be honest I'm also unfamiliar with this code. (IIUC, unfortunately,
> > no one actively working on Chromium is familiar with this dbus::Property
> > code)
> > It'd be appreciated if you could make this change separately as
> > suggested by Steven.
> >
> > https://codereview.chromium.org/2009753002/

The property change isn't necessary, I'm dropping it. I've split out some of
the other bluez test changes to https://codereview.chromium.org/2167013002/

[scheib, 2016-07-21 01:00:18]

The CQ bit was unchecked by scheib@chromium.org

[scheib, 2016-07-21 01:00:21]

The CQ bit was checked by scheib@chromium.org

[scheib, 2016-07-21 01:00:21]

The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org,
reillyg@chromium.org
Link to the patchset: https://codereview.chromium.org/2009753002/#ps280001
(title: "split out name/alias")

[commit-bot: I haz the power, 2016-07-21 01:00:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 01:20:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 01:20:06]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[scheib, 2016-07-21 03:55:13]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2016-07-21 03:55:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 04:10:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-21 04:10:52]

Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[scheib, 2016-07-21 05:42:55]

The CQ bit was checked by scheib@chromium.org

[commit-bot: I haz the power, 2016-07-21 05:43:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-21 07:06:20]

Description was changed from

==========
bluetooth: Make public BluetoothDevice::GetName method.

This change prepares for http://crrev.com/2014473002
which will allow Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.

GetDeviceName is moved from a protected method to a public method
GetNameOrEmpty.

http://crrev.com/2017393002 GetName -> GetNameForDisplay
http://crrev.com/2009753002 New GetName <<< This change.
http://crrev.com/2014473002 Web Bluetooth updated
http://crrev.com/2020923002 Arc Bridge updated

BUG=615720
==========

to

==========
bluetooth: Make public BluetoothDevice::GetName method.

This change prepares for http://crrev.com/2014473002
which will allow Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.

GetDeviceName is moved from a protected method to a public method
GetNameOrEmpty.

http://crrev.com/2017393002 GetName -> GetNameForDisplay
http://crrev.com/2009753002 New GetName <<< This change.
http://crrev.com/2014473002 Web Bluetooth updated
http://crrev.com/2020923002 Arc Bridge updated

BUG=615720
==========

[commit-bot: I haz the power, 2016-07-21 07:06:23]

Committed patchset #9 (id:280001)

[commit-bot: I haz the power, 2016-07-21 07:07:51]

Description was changed from

==========
bluetooth: Make public BluetoothDevice::GetName method.

This change prepares for http://crrev.com/2014473002
which will allow Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.

GetDeviceName is moved from a protected method to a public method
GetNameOrEmpty.

http://crrev.com/2017393002 GetName -> GetNameForDisplay
http://crrev.com/2009753002 New GetName <<< This change.
http://crrev.com/2014473002 Web Bluetooth updated
http://crrev.com/2020923002 Arc Bridge updated

BUG=615720
==========

to

==========
bluetooth: Make public BluetoothDevice::GetName method.

This change prepares for http://crrev.com/2014473002
which will allow Web Bluetooth to filter by unnamed devices and
avoid disclosing MAC addresses to web pages.

GetDeviceName is moved from a protected method to a public method
GetNameOrEmpty.

http://crrev.com/2017393002 GetName -> GetNameForDisplay
http://crrev.com/2009753002 New GetName <<< This change.
http://crrev.com/2014473002 Web Bluetooth updated
http://crrev.com/2020923002 Arc Bridge updated

BUG=615720

Committed: https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7
Cr-Commit-Position: refs/heads/master@{#406790}
==========

[commit-bot: I haz the power, 2016-07-21 07:07:53]

Patchset 9 (id:??) landed as
https://crrev.com/dd9ce700bede9a707b4b7991ba72417c48cebce7
Cr-Commit-Position: refs/heads/master@{#406790}