bluetooth: Make public BluetoothDevice::GetName method.

device/bluetooth/bluetooth_classic_device_mac.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_classic_device_mac.h"
 
 #include <string>
 
 #include "base/bind.h"
 #include "base/hash.h"
@@ skipping 53 matching lines @@
     IOBluetoothDevice* device)
     : BluetoothDeviceMac(adapter), device_([device retain]) {}
 
 BluetoothClassicDeviceMac::~BluetoothClassicDeviceMac() {
 }
 
 uint32_t BluetoothClassicDeviceMac::GetBluetoothClass() const {
   return [device_ classOfDevice];
 }
 
-std::string BluetoothClassicDeviceMac::GetDeviceName() const {
-  return base::SysNSStringToUTF8([device_ name]);
-}
-
 void BluetoothClassicDeviceMac::CreateGattConnectionImpl() {
   // Classic devices do not support GATT connection.
   DidFailToConnectGatt(ERROR_UNSUPPORTED_DEVICE);
 }
 
 void BluetoothClassicDeviceMac::DisconnectGatt() {}
 
 std::string BluetoothClassicDeviceMac::GetAddress() const {
   return GetDeviceAddress(device_);
 }
@@ skipping 15 matching lines @@
   return 0;
 }
 
 uint16_t BluetoothClassicDeviceMac::GetAppearance() const {
   // TODO(crbug.com/588083): Implementing GetAppearance()
   // on mac, win, and android platforms for chrome
   NOTIMPLEMENTED();
   return 0;
 }
 
+base::Optional<std::string> BluetoothClassicDeviceMac::GetName() const {
+  if ([device_ name])
+    return base::Optional<std::string>(base::SysNSStringToUTF8([device_ name]));
+  return base::Optional<std::string>();

[ortuno, 2016/07/14 21:11:41]

any reason why you don't use base::make_optional and base::nullopt?

[scheib, 2016/07/16 00:21:36]

Done.

+}
+
 bool BluetoothClassicDeviceMac::IsPaired() const {
   return [device_ isPaired];
 }
 
 bool BluetoothClassicDeviceMac::IsConnected() const {
   return [device_ isConnected];
 }
 
 bool BluetoothClassicDeviceMac::IsGattConnected() const {
   return false;  // Classic devices do not support GATT connection.
@@ skipping 158 matching lines @@
   return power_level;
 }
 
 // static
 std::string BluetoothClassicDeviceMac::GetDeviceAddress(
     IOBluetoothDevice* device) {
   return CanonicalizeAddress(base::SysNSStringToUTF8([device addressString]));
 }
 
 }  // namespace device