bluetooth: Make public BluetoothDevice::GetName method.

device/bluetooth/bluetooth_low_energy_win.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "device/bluetooth/bluetooth_low_energy_win.h"
 
 #include <memory>
 #include <utility>
 
 #include "base/files/file.h"
@@ skipping 449 matching lines @@
   }
 
   std::unique_ptr<device::win::BluetoothLowEnergyDeviceInfo> result(
       new device::win::BluetoothLowEnergyDeviceInfo());
   result->path =
       base::FilePath(std::wstring(device_interface_detail_data->DevicePath));
   if (!CollectBluetoothLowEnergyDeviceInstanceId(
           device_info_handle, &device_info_data, result, error)) {
     return false;
   }
-  if (!CollectBluetoothLowEnergyDeviceFriendlyName(
-          device_info_handle, &device_info_data, result, error)) {
-    // Only fail if not the GATT service device interface, which doesn't have a
-    // friendly name.
-    if (device_interface_data->InterfaceClassGuid !=

[ortuno, 2016/07/14 21:11:41]

Hmm this would mean that we no longer fail if we can't get the device's name
which I guess is OK, but I wish we knew if we are always expected to be able to
get a name...

[scheib, 2016/07/16 00:21:36]

Acknowledged, would be great to know if we'd always get one or not. But since we
can tolerate not receiving one I don't see a need for the awkward old check.

-        GUID_BLUETOOTH_GATT_SERVICE_DEVICE_INTERFACE)
-      return false;
-  }
+  CollectBluetoothLowEnergyDeviceFriendlyName(device_info_handle,
+                                              &device_info_data, result, error);
   if (!CollectBluetoothLowEnergyDeviceAddress(
           device_info_handle, &device_info_data, result, error)) {
     return false;
   }
   if (!CollectBluetoothLowEnergyDeviceStatus(
           device_info_handle, &device_info_data, result, error)) {
     return false;
   }
   (*device_info) = std::move(result);
   return true;
@@ skipping 375 matching lines @@
   base::File file(service_path, base::File::FLAG_OPEN | base::File::FLAG_READ |
                                     base::File::FLAG_WRITE);
   if (!file.IsValid())
     return HRESULT_FROM_WIN32(ERROR_OPEN_FAILED);
   return BluetoothGATTSetDescriptorValue(file.GetPlatformFile(), descriptor,
                                          new_value, BLUETOOTH_GATT_FLAG_NONE);
 }
 
 }  // namespace win
 }  // namespace device