Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 200943003: ninja/mac: Fix multiarch link regression caused by 1871. (Closed)

Created:
6 years, 9 months ago by Nico
Modified:
6 years, 9 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja/mac: Fix multiarch link regression caused by 1871. BUG=chromium:352816 landed at https://codereview.chromium.org/196283023/

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M pylib/gyp/generator/ninja.py View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
scottmg
lgtm me with a test.
6 years, 9 months ago (2014-03-14 22:47:01 UTC) #1
Nico
6 years, 9 months ago (2014-03-14 23:56:31 UTC) #2
Uploaded with tests at https://codereview.chromium.org/196283023 (different
computer + svn = reupload :-/)

Powered by Google App Engine
This is Rietveld 408576698