Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(430)

Issue 196283023: ninja/mac: Fix multiarch link regression caused by 1871. (Closed)

Created:
6 years, 9 months ago by Nico
Modified:
6 years, 9 months ago
Reviewers:
scottmg
CC:
gyp-developer_googlegroups.com
Visibility:
Public.

Description

ninja/mac: Fix multiarch link regression caused by 1871. The bug was caused by i386 and x86_64 binary using the same rsp file. Add arch to rsp filename in multi-arch builds. (ld64 prints a warning about .o files not having the right arch when linking the 64bit version using the rsp file written for the 32bit link and the other way round and silently skips the .o file, but it exits with 0. To test for this, get symbols from the final fat binary in each arch and check that they are all there -- this fails fairly reliably without the patch, even though it depends on process invocation order.) BUG=chromium:352816 TBR=scottmg@chromium.org (lg'd at https://codereview.chromium.org/200943003/) Committed: https://code.google.com/p/gyp/source/detail?r=1874

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -4 lines) Patch
M pylib/gyp/generator/ninja.py View 1 chunk +5 lines, -2 lines 0 comments Download
M test/mac/archs/test-archs-multiarch.gyp View 2 chunks +20 lines, -0 lines 0 comments Download
M test/mac/gyptest-archs.py View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Nico
6 years, 9 months ago (2014-03-14 23:57:17 UTC) #1
Nico
Committed patchset #1 manually as r1874 (presubmit successful).
6 years, 9 months ago (2014-03-15 00:05:28 UTC) #2
scottmg
6 years, 9 months ago (2014-03-15 00:17:48 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698