Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2009413002: Remove parameters which are always null (Closed)

Created:
4 years, 7 months ago by dsinclair
Modified:
4 years, 7 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Remove parameters which are always null These parameters are never set, remove them and their supporting code. Committed: https://pdfium.googlesource.com/pdfium/+/818e1900a3811e1bde1e594e4966db612f845966

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+138 lines, -221 lines) Patch
M xfa/fxfa/app/xfa_ffdochandler.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M xfa/fxfa/fm2js/xfa_fm2jscontext.cpp View 111 chunks +115 lines, -181 lines 0 comments Download
M xfa/fxfa/parser/xfa_script.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxfa/parser/xfa_script_hostpseudomodel.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M xfa/fxfa/parser/xfa_script_imp.cpp View 9 chunks +9 lines, -14 lines 0 comments Download
M xfa/fxjse/cfxjse_arguments.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxjse/class.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M xfa/fxjse/include/fxjse.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxjse/util_inline.h View 2 chunks +1 line, -10 lines 0 comments Download
M xfa/fxjse/value.h View 1 chunk +1 line, -1 line 0 comments Download
M xfa/fxjse/value.cpp View 3 chunks +4 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dsinclair
PTAL.
4 years, 7 months ago (2016-05-26 02:19:59 UTC) #2
Lei Zhang
lgtm
4 years, 7 months ago (2016-05-26 02:33:58 UTC) #3
Lei Zhang
s/only/always/ ?
4 years, 7 months ago (2016-05-26 02:34:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2009413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2009413002/1
4 years, 7 months ago (2016-05-26 02:36:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://pdfium.googlesource.com/pdfium/+/818e1900a3811e1bde1e594e4966db612f845966
4 years, 7 months ago (2016-05-26 02:37:03 UTC) #9
Tom Sepez
Not LGTM. Can we revert? I suspect that the lack of this parameter being passed ...
4 years, 7 months ago (2016-05-26 15:36:59 UTC) #10
dsinclair
4 years, 7 months ago (2016-05-26 15:41:33 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2014863002/ by dsinclair@chromium.org.

The reason for reverting is: Suspect that the lack of this parameter being
passed accurately to GetObject is leading to
https://bugs.chromium.org/p/chromium/issues/detail?id=613607, and that the right
fix will be to pass it..

Powered by Google App Engine
This is Rietveld 408576698