xfa/fxfa/app/xfa_ffdochandler.cpp - Issue 2009413002: Remove parameters which are always null

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: xfa/fxfa/app/xfa_ffdochandler.cpp

Issue 2009413002: Remove parameters which are always null (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | xfa/fxfa/fm2js/xfa_fm2jscontext.cpp » ('j') | no next file with comments »

OLD	NEW
1 // Copyright 2014 PDFium Authors. All rights reserved.	1 // Copyright 2014 PDFium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com	5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com

6	6

7 #include "xfa/fxfa/include/xfa_ffdochandler.h"	7 #include "xfa/fxfa/include/xfa_ffdochandler.h"

8	8

9 #include "xfa/fxfa/include/xfa_checksum.h"	9 #include "xfa/fxfa/include/xfa_checksum.h"

10 #include "xfa/fxfa/include/xfa_ffdoc.h"	10 #include "xfa/fxfa/include/xfa_ffdoc.h"

(...skipping 38 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
49 CXFA_Document* pXFADoc = hDoc->GetXFADoc();	49 CXFA_Document* pXFADoc = hDoc->GetXFADoc();

50 if (!pXFADoc)	50 if (!pXFADoc)

51 return FALSE;	51 return FALSE;

52	52

53 CXFA_ScriptContext* pScriptContext = pXFADoc->GetScriptContext();	53 CXFA_ScriptContext* pScriptContext = pXFADoc->GetScriptContext();

54 if (!pScriptContext)	54 if (!pScriptContext)

55 return FALSE;	55 return FALSE;

56	56

57 return pScriptContext->RunScript(	57 return pScriptContext->RunScript(

58 (XFA_SCRIPTLANGTYPE)eScriptType, wsScript, hRetValue,	58 (XFA_SCRIPTLANGTYPE)eScriptType, wsScript, hRetValue,

59 hThisObject ? (CXFA_Object*)FXJSE_Value_ToObject(hThisObject, nullptr)	59 hThisObject ? (CXFA_Object*)FXJSE_Value_ToObject(hThisObject) : nullptr);

60 : nullptr);

61 }	60 }

OLD	NEW