Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Side by Side Diff: xfa/fxjse/util_inline.h

Issue 2009413002: Remove parameters which are always null (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « xfa/fxjse/include/fxjse.h ('k') | xfa/fxjse/value.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 PDFium Authors. All rights reserved. 1 // Copyright 2014 PDFium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com 5 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
6 6
7 #ifndef XFA_FXJSE_UTIL_INLINE_H_ 7 #ifndef XFA_FXJSE_UTIL_INLINE_H_
8 #define XFA_FXJSE_UTIL_INLINE_H_ 8 #define XFA_FXJSE_UTIL_INLINE_H_
9 9
10 #include "xfa/fxjse/context.h" 10 #include "xfa/fxjse/context.h"
11 11
12 static V8_INLINE v8::Local<v8::Object> FXJSE_GetGlobalObjectFromContext( 12 static V8_INLINE v8::Local<v8::Object> FXJSE_GetGlobalObjectFromContext(
13 const v8::Local<v8::Context>& hContext) { 13 const v8::Local<v8::Context>& hContext) {
14 return hContext->Global()->GetPrototype().As<v8::Object>(); 14 return hContext->Global()->GetPrototype().As<v8::Object>();
15 } 15 }
16 static V8_INLINE void FXJSE_UpdateObjectBinding(v8::Local<v8::Object>& hObject, 16 static V8_INLINE void FXJSE_UpdateObjectBinding(v8::Local<v8::Object>& hObject,
17 void* lpNewBinding) { 17 void* lpNewBinding) {
18 ASSERT(!hObject.IsEmpty()); 18 ASSERT(!hObject.IsEmpty());
19 ASSERT(hObject->InternalFieldCount() > 0); 19 ASSERT(hObject->InternalFieldCount() > 0);
20 hObject->SetAlignedPointerInInternalField(0, lpNewBinding); 20 hObject->SetAlignedPointerInInternalField(0, lpNewBinding);
21 } 21 }
22 static V8_INLINE void* FXJSE_RetrieveObjectBinding( 22 static V8_INLINE void* FXJSE_RetrieveObjectBinding(
23 const v8::Local<v8::Object>& hJSObject, 23 const v8::Local<v8::Object>& hJSObject) {
24 CFXJSE_Class* lpClass = NULL) {
25 ASSERT(!hJSObject.IsEmpty()); 24 ASSERT(!hJSObject.IsEmpty());
26 if (!hJSObject->IsObject()) { 25 if (!hJSObject->IsObject()) {
27 return NULL; 26 return NULL;
28 } 27 }
29 v8::Local<v8::Object> hObject = hJSObject; 28 v8::Local<v8::Object> hObject = hJSObject;
30 if (hObject->InternalFieldCount() == 0) { 29 if (hObject->InternalFieldCount() == 0) {
31 v8::Local<v8::Value> hProtoObject = hObject->GetPrototype(); 30 v8::Local<v8::Value> hProtoObject = hObject->GetPrototype();
32 if (hProtoObject.IsEmpty() || !hProtoObject->IsObject()) { 31 if (hProtoObject.IsEmpty() || !hProtoObject->IsObject()) {
33 return NULL; 32 return NULL;
34 } 33 }
35 hObject = hProtoObject.As<v8::Object>(); 34 hObject = hProtoObject.As<v8::Object>();
36 if (hObject->InternalFieldCount() == 0) { 35 if (hObject->InternalFieldCount() == 0) {
37 return NULL; 36 return NULL;
38 } 37 }
39 } 38 }
40 if (lpClass) {
41 v8::Local<v8::FunctionTemplate> hClass =
42 v8::Local<v8::FunctionTemplate>::New(
43 lpClass->GetContext()->GetRuntime(), lpClass->GetTemplate());
44 if (!hClass->HasInstance(hObject)) {
45 return NULL;
46 }
47 }
48 return hObject->GetAlignedPointerFromInternalField(0); 39 return hObject->GetAlignedPointerFromInternalField(0);
49 } 40 }
50 41
51 #endif // XFA_FXJSE_UTIL_INLINE_H_ 42 #endif // XFA_FXJSE_UTIL_INLINE_H_
OLDNEW
« no previous file with comments | « xfa/fxjse/include/fxjse.h ('k') | xfa/fxjse/value.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698