Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 2008003002: Add define to keep old SkTypeface::MakeFromName. (Closed)

Created:
4 years, 7 months ago by bungeman-chromium
Modified:
4 years, 7 months ago
Reviewers:
bungeman-skia, Mikus
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add define to keep old SkTypeface::MakeFromName. The signature of SkTypeface::MakeFromName is changing, this define will keep the old signature in existence until Chromium can be converted. Committed: https://crrev.com/932bd23be9a6b3738ec2f3593fa2fdf8326d5ab2 Cr-Commit-Position: refs/heads/master@{#395683}

Patch Set 1 #

Patch Set 2 : Forgot the quotes. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M skia/chromium_skia_defines.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008003002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008003002/1
4 years, 7 months ago (2016-05-24 17:44:00 UTC) #2
bungeman-chromium
4 years, 7 months ago (2016-05-24 17:46:17 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/builds/10724) mac_chromium_compile_dbg_ng on ...
4 years, 7 months ago (2016-05-24 17:47:38 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008003002/20001
4 years, 7 months ago (2016-05-24 17:54:20 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-24 19:17:47 UTC) #10
bungeman-skia
lgtm
4 years, 7 months ago (2016-05-24 20:08:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2008003002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2008003002/20001
4 years, 7 months ago (2016-05-24 20:09:07 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 20:14:34 UTC) #15
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 20:15:47 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/932bd23be9a6b3738ec2f3593fa2fdf8326d5ab2
Cr-Commit-Position: refs/heads/master@{#395683}

Powered by Google App Engine
This is Rietveld 408576698