Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Side by Side Diff: skia/chromium_skia_defines.gypi

Issue 2008003002: Add define to keep old SkTypeface::MakeFromName. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Forgot the quotes. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 { 4 {
5 'variables': { 5 'variables': {
6 6
7 # This is a place for defines which will hold out Skia changes. 7 # This is a place for defines which will hold out Skia changes.
8 # 8 #
9 # When Skia needs to make a change which will affect Chromium, a define may 9 # When Skia needs to make a change which will affect Chromium, a define may
10 # be added here, the Skia change made behind this define, then Skia rolled 10 # be added here, the Skia change made behind this define, then Skia rolled
11 # into Chromium. At this point the Chromium side change can be made while 11 # into Chromium. At this point the Chromium side change can be made while
12 # also removing the define. After this Skia can remove the code behind the 12 # also removing the define. After this Skia can remove the code behind the
13 # now no longer needed define. 13 # now no longer needed define.
14 # 14 #
15 # Examples of these sorts of changes are Skia API changes and Skia changes 15 # Examples of these sorts of changes are Skia API changes and Skia changes
16 # which will affect blink baselines. 16 # which will affect blink baselines.
17 # 17 #
18 # The intent is that the defines here are transient. Every effort should be 18 # The intent is that the defines here are transient. Every effort should be
19 # made to remove these defines as soon as practical. This is in contrast to 19 # made to remove these defines as soon as practical. This is in contrast to
20 # defines in SkUserConfig.h which are normally more permanent. 20 # defines in SkUserConfig.h which are normally more permanent.
21 'chromium_skia_defines': [ 21 'chromium_skia_defines': [
22 'SK_SUPPORT_LEGACY_TYPEFACE_MAKE_FROM_NAME',
22 ], 23 ],
23 }, 24 },
24 } 25 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698