Use Init dictionaries in RTCPeerConnection legacy methods.

Use Init dictionaries in RTCPeerConnection legacy methods.

In addition, correctly handle the conversion to WebRTCIceCandidate when given a valid RTCIceCandidateInit with null sdpMLineIndex.

BUG=612118
Committed: https://crrev.com/93ba0b84e5d94b8da6ddf025b62f0ac3c2f8c79a
Cr-Commit-Position: refs/heads/master@{#396449}

[Guido Urdaneta, 2016-05-24 13:55:58]

Description was changed from

==========
Use Init dictionaries in RTCPeerConnection legacy methods.

BUG=612118
==========

to

==========
Use Init dictionaries in RTCPeerConnection legacy methods.

In addition, correctly handle the conversion to WebRTCIceCandidate when given a
valid RTCIceCandidateInit with null sdpMLineIndex.

BUG=612118
==========

[Guido Urdaneta, 2016-05-24 14:10:19]

guidou@chromium.org changed reviewers:
+ peter@chromium.org

[Guido Urdaneta, 2016-05-24 14:10:20]

Hi, can you take a look?

[Guido Urdaneta, 2016-05-25 08:45:29]

The CQ bit was checked by guidou@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-25 08:45:41]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007923003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007923003/20001

[commit-bot: I haz the power, 2016-05-25 08:49:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-25 08:49:27]

Dry run: This issue passed the CQ dry run.

[commit-bot: I haz the power, 2016-05-25 08:49:34]

Dry run: None

[hta - Chromium, 2016-05-26 04:56:40]

hta@chromium.org changed reviewers:
+ hta@chromium.org

[hta - Chromium, 2016-05-26 04:56:41]

Seems good, but we need to count the zeroes.

Do you need to follow the instructions in
third_party/WebKit/Source/bindings/IDLUnionTypes.md to explicitly list the
generated files for the unions you're using?

https://codereview.chromium.org/2007923003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html
(right):

https://codereview.chromium.org/2007923003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html:21:
function addIceCandidateSuccess1()
Is it time to rewrite this test as a testharness.js test?

https://codereview.chromium.org/2007923003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp
(right):

https://codereview.chromium.org/2007923003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp:160:
unsigned short sdpMLineIndex = iceCandidateInit.hasSdpMLineIndex() ?
iceCandidateInit.sdpMLineIndex() : 0;
Count the number of times this zeroes, and add a TODO to make the default -1
(aka illegal).

[Guido Urdaneta, 2016-05-26 14:37:34]

guidou@chromium.org changed reviewers:
+ holte@chromium.org, japhet@chromium.org

[Guido Urdaneta, 2016-05-26 14:37:37]

japhet@chromium.org: Please review changes in WebKit/public/platform and
UseCounter.h

holte@chromium.org: Please review changes in histogram.xml

https://codereview.chromium.org/2007923003/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html
(right):

https://codereview.chromium.org/2007923003/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html:21:
function addIceCandidateSuccess1()
On 2016/05/26 04:56:41, hta - Chromium wrote:
> Is it time to rewrite this test as a testharness.js test?

Created a bug to migrate all mediastream tests and added TODO here.

https://codereview.chromium.org/2007923003/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp
(right):

https://codereview.chromium.org/2007923003/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp:160:
unsigned short sdpMLineIndex = iceCandidateInit.hasSdpMLineIndex() ?
iceCandidateInit.sdpMLineIndex() : 0;
On 2016/05/26 04:56:41, hta - Chromium wrote:
> Count the number of times this zeroes, and add a TODO to make the default -1
> (aka illegal).

Done.

[hta - Chromium, 2016-05-26 15:14:09]

lgtm

[Steven Holte, 2016-05-26 19:52:26]

You'll probably conflict with this change:
https://codereview.chromium.org/2014153002/patch/1/10003

lgtm, with maybe a rebase

[Nate Chapin, 2016-05-26 20:22:37]

lgtm

[Guido Urdaneta, 2016-05-27 09:18:00]

guidou@chromium.org changed reviewers:
+ tommi@chromium.org
- peter@chromium.org

[Guido Urdaneta, 2016-05-27 09:18:37]

tommi: please review WebKit/Source/modules/mediastream

[tommi (sloooow) - chröme, 2016-05-27 09:40:58]

lgtm

[Guido Urdaneta, 2016-05-27 10:54:02]

The CQ bit was checked by guidou@chromium.org

[Guido Urdaneta, 2016-05-27 10:54:02]

The patchset sent to the CQ was uploaded after l-g-t-m from japhet@chromium.org,
hta@chromium.org, tommi@chromium.org, holte@chromium.org
Link to the patchset: https://codereview.chromium.org/2007923003/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-05-27 10:54:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2007923003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2007923003/60001

[commit-bot: I haz the power, 2016-05-27 12:46:43]

Description was changed from

==========
Use Init dictionaries in RTCPeerConnection legacy methods.

In addition, correctly handle the conversion to WebRTCIceCandidate when given a
valid RTCIceCandidateInit with null sdpMLineIndex.

BUG=612118
==========

to

==========
Use Init dictionaries in RTCPeerConnection legacy methods.

In addition, correctly handle the conversion to WebRTCIceCandidate when given a
valid RTCIceCandidateInit with null sdpMLineIndex.

BUG=612118
==========

[commit-bot: I haz the power, 2016-05-27 12:46:44]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-05-27 12:48:13]

Description was changed from

==========
Use Init dictionaries in RTCPeerConnection legacy methods.

In addition, correctly handle the conversion to WebRTCIceCandidate when given a
valid RTCIceCandidateInit with null sdpMLineIndex.

BUG=612118
==========

to

==========
Use Init dictionaries in RTCPeerConnection legacy methods.

In addition, correctly handle the conversion to WebRTCIceCandidate when given a
valid RTCIceCandidateInit with null sdpMLineIndex.

BUG=612118

Committed: https://crrev.com/93ba0b84e5d94b8da6ddf025b62f0ac3c2f8c79a
Cr-Commit-Position: refs/heads/master@{#396449}
==========

[commit-bot: I haz the power, 2016-05-27 12:48:15]

Patchset 4 (id:??) landed as
https://crrev.com/93ba0b84e5d94b8da6ddf025b62f0ac3c2f8c79a
Cr-Commit-Position: refs/heads/master@{#396449}