third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html - Issue 2007923003: Use Init dictionaries in RTCPeerConnection legacy methods.

Unified Diff: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html

Issue 2007923003: Use Init dictionaries in RTCPeerConnection legacy methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html

diff --git a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html

index dff8fd217b2b3a3e8d2c5db6ae4c3ca86585fa20..aa189d6f9178cd106dc8f9d5bfb6426e35ea9c1f 100644

--- a/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html

+++ b/third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice.html

@@ -2,6 +2,7 @@

<html>

<head>

+

</head>

<body>

@@ -18,9 +19,27 @@ function onIceChange2()

}

-function addIceCandidateSuccess()

+function addIceCandidateSuccess1()

{

- testPassed("addIceCandidateSuccess was called.");

+ testPassed("addIceCandidateSuccess1 was called.");

+ shouldNotThrow('pc.addIceCandidate({candidate: "candidate", sdpMid: 0}, addIceCandidateSuccess2, unexpectedCallback);');

+function addIceCandidateSuccess2()

+ testPassed("addIceCandidateSuccess2 was called.");

+ shouldNotThrow('pc.addIceCandidate({candidate: "candidate", sdpMLineIndex: 0}, addIceCandidateSuccess3, unexpectedCallback);');

+function addIceCandidateSuccess3()

+ testPassed("addIceCandidateSuccess3 was called.");

+ shouldNotThrow('pc.addIceCandidate({candidate: "candidate", sdpMid: 0, sdpMLineIndex: 0}, addIceCandidateSuccess4, unexpectedCallback);');

+function addIceCandidateSuccess4()

+ testPassed("addIceCandidateSuccess4 was called.");

pc.oniceconnectionstatechange = onIceChange2;

pc.close();

}

@@ -43,10 +62,11 @@ function onIceChange1()

if (pc.iceConnectionState === "completed") {

testPassed("iceConnectionState is completed");

iceCandidate = new RTCIceCandidate({candidate:"nano nano"});

- shouldNotThrow('pc.addIceCandidate(null, addIceCandidateSuccess, unexpectedCallback).catch(expectedTypeError);');

+ shouldNotThrow('pc.addIceCandidate(null, unexpectedCallback, unexpectedCallback).catch(expectedTypeError);');

+ shouldNotThrow('pc.addIceCandidate({candidate: "candidate"}, unexpectedCallback, unexpectedCallback).catch(expectedTypeError);');

shouldNotThrow('pc.addIceCandidate(iceCandidate, null, unexpectedCallback).catch(expectedTypeError);');

- shouldNotThrow('pc.addIceCandidate(iceCandidate, addIceCandidateSuccess, null).catch(expectedTypeError);');

- shouldNotThrow('pc.addIceCandidate(iceCandidate, addIceCandidateSuccess, unexpectedCallback);');

+ shouldNotThrow('pc.addIceCandidate(iceCandidate, unexpectedCallback, null).catch(expectedTypeError);');

+ shouldNotThrow('pc.addIceCandidate(iceCandidate, addIceCandidateSuccess1, unexpectedCallback);');

}

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/mediastream/RTCPeerConnection-ice-expected.txt » ('j') | no next file with comments »