third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl - Issue 2007923003: Use Init dictionaries in RTCPeerConnection legacy methods.

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

Issue 2007923003: Use Init dictionaries in RTCPeerConnection legacy methods. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.cpp ('k') | third_party/WebKit/public/platform/WebRTCICECandidate.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

diff --git a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

index aa39b37b7dacaa8dd5c4958c5fb687484f9b0255..1afa9291abfb67d05ebca101393fbcccedb1385e 100644

--- a/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

+++ b/third_party/WebKit/Source/modules/mediastream/RTCPeerConnection.idl

@@ -80,7 +80,7 @@ enum RTCIceConnectionState {

readonly attribute RTCSessionDescription? remoteDescription;

// readonly attribute RTCSessionDescription? currentRemoteDescription;

// readonly attribute RTCSessionDescription? pendingRemoteDescription;

- [CallWith=ScriptState] Promise<void> addIceCandidate ((RTCIceCandidateInit or RTCIceCandidate) candidate);

+ [CallWith=ScriptState, MeasureAs=RTCPeerConnectionAddIceCandidatePromise] Promise<void> addIceCandidate ((RTCIceCandidateInit or RTCIceCandidate) candidate);

readonly attribute RTCSignalingState signalingState;

readonly attribute RTCIceGatheringState iceGatheringState;

readonly attribute RTCIceConnectionState iceConnectionState;

@@ -100,10 +100,10 @@ enum RTCIceConnectionState {

[CallWith=ScriptState] Promise<void> createOffer(RTCSessionDescriptionCallback successCallback, RTCPeerConnectionErrorCallback failureCallback, optional Dictionary rtcOfferOptions);

// TODO(guidou): There should be no mediaConstraints argument.

[CallWith=ScriptState] Promise<void> createAnswer(RTCSessionDescriptionCallback successCallback, RTCPeerConnectionErrorCallback failureCallback, optional Dictionary mediaConstraints);

- [CallWith=ScriptState] Promise<void> setLocalDescription(RTCSessionDescription description, VoidCallback successCallback, [Default=Undefined] optional RTCPeerConnectionErrorCallback failureCallback);

+ [CallWith=ScriptState] Promise<void> setLocalDescription(RTCSessionDescriptionInit description, VoidCallback successCallback, [Default=Undefined] optional RTCPeerConnectionErrorCallback failureCallback);

// TODO(guidou): The failureCallback argument should be non-optional.

- [CallWith=ScriptState] Promise<void> setRemoteDescription(RTCSessionDescription description, VoidCallback successCallback, [Default=Undefined] optional RTCPeerConnectionErrorCallback failureCallback);

- [CallWith=ScriptState] Promise<void> addIceCandidate(RTCIceCandidate candidate, VoidCallback successCallback, RTCPeerConnectionErrorCallback failureCallback);

+ [CallWith=ScriptState] Promise<void> setRemoteDescription(RTCSessionDescriptionInit description, VoidCallback successCallback, [Default=Undefined] optional RTCPeerConnectionErrorCallback failureCallback);

+ [CallWith=ScriptState, MeasureAs=RTCPeerConnectionAddIceCandidateLegacy] Promise<void> addIceCandidate((RTCIceCandidateInit or RTCIceCandidate) candidate, VoidCallback successCallback, RTCPeerConnectionErrorCallback failureCallback);

// TODO(guidou): The selector argument should the first (nullable,

// non-optional) argument, and there should be a third failureCallback

// argument.