third_party/WebKit/Source/core/testing/UnionTypesTest.cpp - Issue 2007103003: Expand WTF::StringView's API to be more like StringPiece.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/UnionTypesTest.cpp

Issue 2007103003: Expand WTF::StringView's API to be more like StringPiece. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove bad assert. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/testing/MockHyphenation.cpp ('k') | third_party/WebKit/Source/platform/animation/TimingFunction.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/testing/UnionTypesTest.cpp

diff --git a/third_party/WebKit/Source/core/testing/UnionTypesTest.cpp b/third_party/WebKit/Source/core/testing/UnionTypesTest.cpp

index 3e134f78931103f0b586b1a33ea28b118603cc85..ebb3aabc6dc3325fc079a31673603518585f1427 100644

--- a/third_party/WebKit/Source/core/testing/UnionTypesTest.cpp

+++ b/third_party/WebKit/Source/core/testing/UnionTypesTest.cpp

@@ -75,12 +75,15 @@ String UnionTypesTest::doubleOrStringArrayArg(HeapVector<DoubleOrString>& array)

StringBuilder builder;

for (DoubleOrString& doubleOrString : array) {

ASSERT(!doubleOrString.isNull());

- if (doubleOrString.isDouble())

- builder.append("double: " + String::numberToStringECMAScript(doubleOrString.getAsDouble()));

- else if (doubleOrString.isString())

- builder.append("string: " + doubleOrString.getAsString());

- else

+ if (doubleOrString.isDouble()) {

+ builder.append("double: ");

+ builder.append(String::numberToStringECMAScript(doubleOrString.getAsDouble()));

+ } else if (doubleOrString.isString()) {

+ builder.append("string: ");

+ builder.append(doubleOrString.getAsString());

+ } else {

ASSERT_NOT_REACHED();

+ }

builder.append(", ");

}

return builder.substring(0, builder.length() - 2);