third_party/WebKit/Source/platform/animation/TimingFunction.cpp - Issue 2007103003: Expand WTF::StringView's API to be more like StringPiece.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/animation/TimingFunction.cpp

Issue 2007103003: Expand WTF::StringView's API to be more like StringPiece. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove bad assert. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/testing/UnionTypesTest.cpp ('k') | third_party/WebKit/Source/platform/exported/WebString.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/animation/TimingFunction.cpp

diff --git a/third_party/WebKit/Source/platform/animation/TimingFunction.cpp b/third_party/WebKit/Source/platform/animation/TimingFunction.cpp

index 52c16dde646b4703e9c1ef462a91779a2fce12d2..de8bf896f34448417550ef0f08675133d649c1be 100644

--- a/third_party/WebKit/Source/platform/animation/TimingFunction.cpp

+++ b/third_party/WebKit/Source/platform/animation/TimingFunction.cpp

@@ -127,7 +127,9 @@ String StepsTimingFunction::toString() const

builder.append("step-");

builder.append(positionString);

} else {

- builder.append("steps(" + String::numberToStringECMAScript(this->numberOfSteps()) + ", ");

+ builder.append("steps(");

+ builder.append(String::numberToStringECMAScript(this->numberOfSteps()));

+ builder.append(", ");

builder.append(positionString);

builder.append(')');

}