third_party/WebKit/Source/core/testing/MockHyphenation.cpp - Issue 2007103003: Expand WTF::StringView's API to be more like StringPiece.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/testing/MockHyphenation.cpp

Issue 2007103003: Expand WTF::StringView's API to be more like StringPiece. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove bad assert. Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/paint/InlineTextBoxPainter.cpp ('k') | third_party/WebKit/Source/core/testing/UnionTypesTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/testing/MockHyphenation.cpp

diff --git a/third_party/WebKit/Source/core/testing/MockHyphenation.cpp b/third_party/WebKit/Source/core/testing/MockHyphenation.cpp

index 5e166d9a0dfdbbadf403973cd5e675d18980ed1e..08e1d6991bf435db98d7d301c9b0746e8c9eabfb 100644

--- a/third_party/WebKit/Source/core/testing/MockHyphenation.cpp

+++ b/third_party/WebKit/Source/core/testing/MockHyphenation.cpp

@@ -9,13 +9,13 @@ namespace blink {

size_t MockHyphenation::lastHyphenLocation(const StringView& text,

size_t beforeIndex) const

{

- RefPtr<StringImpl> str = text.toString();

- if (str->endsWithIgnoringASCIICase("phenation", 9)) {

- if (beforeIndex - (str->length() - 9) > 4)

- return 4 + (str->length() - 9);

- if (str->endsWithIgnoringASCIICase("hyphenation", 11)

- && beforeIndex - (str->length() - 11) > 2) {

- return 2 + (str->length() - 11);

+ String str = text.toString();

+ if (str.endsWith("phenation", TextCaseASCIIInsensitive)) {

+ if (beforeIndex - (str.length() - 9) > 4)

+ return 4 + (str.length() - 9);

+ if (str.endsWith("hyphenation", TextCaseASCIIInsensitive)

+ && beforeIndex - (str.length() - 11) > 2) {

+ return 2 + (str.length() - 11);

}

return 0;