Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(661)

Unified Diff: third_party/WebKit/Source/core/testing/MockHyphenation.cpp

Issue 2007103003: Expand WTF::StringView's API to be more like StringPiece. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove bad assert. Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/testing/MockHyphenation.cpp
diff --git a/third_party/WebKit/Source/core/testing/MockHyphenation.cpp b/third_party/WebKit/Source/core/testing/MockHyphenation.cpp
index 5e166d9a0dfdbbadf403973cd5e675d18980ed1e..08e1d6991bf435db98d7d301c9b0746e8c9eabfb 100644
--- a/third_party/WebKit/Source/core/testing/MockHyphenation.cpp
+++ b/third_party/WebKit/Source/core/testing/MockHyphenation.cpp
@@ -9,13 +9,13 @@ namespace blink {
size_t MockHyphenation::lastHyphenLocation(const StringView& text,
size_t beforeIndex) const
{
- RefPtr<StringImpl> str = text.toString();
- if (str->endsWithIgnoringASCIICase("phenation", 9)) {
- if (beforeIndex - (str->length() - 9) > 4)
- return 4 + (str->length() - 9);
- if (str->endsWithIgnoringASCIICase("hyphenation", 11)
- && beforeIndex - (str->length() - 11) > 2) {
- return 2 + (str->length() - 11);
+ String str = text.toString();
+ if (str.endsWith("phenation", TextCaseASCIIInsensitive)) {
+ if (beforeIndex - (str.length() - 9) > 4)
+ return 4 + (str.length() - 9);
+ if (str.endsWith("hyphenation", TextCaseASCIIInsensitive)
+ && beforeIndex - (str.length() - 11) > 2) {
+ return 2 + (str.length() - 11);
}
}
return 0;

Powered by Google App Engine
This is Rietveld 408576698