Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2006893004: Store SourceLocation in ErrorEvent. (Closed)

Created:
4 years, 7 months ago by dgozman
Modified:
4 years, 6 months ago
Reviewers:
haraken, sof, pfeldman
CC:
chromium-reviews, kinuko+worker_chromium.org, caseq+blink_chromium.org, horo+watch_chromium.org, blink-reviews-dom_chromium.org, tfarina, sof, eae+blinkwatch, lushnikov+blink_chromium.org, falken, pfeldman+blink_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, blink-reviews-bindings_chromium.org, sergeyv+blink_chromium.org, rwlbuis, blink-worker-reviews_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2010603002
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Store SourceLocation in ErrorEvent. Improves error reporting for syntax error in imported script. This is a follow-up to https://codereview.chromium.org/2010603002/. BUG=613882 Committed: https://crrev.com/83aabb0c32bf01f588292dc992b135f7f2dd22ca Cr-Commit-Position: refs/heads/master@{#396346}

Patch Set 1 #

Patch Set 2 : rebased #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -70 lines) Patch
A + third_party/WebKit/LayoutTests/inspector/console/console-worker-nested-imports-syntax-error.html View 2 chunks +8 lines, -7 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/console/console-worker-nested-imports-syntax-error-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/console/resources/importScripts-1.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/console/resources/importScripts-2.js View 1 chunk +5 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/console/resources/importScripts-3.js View 0 chunks +-1 lines, --1 lines 0 comments Download
A + third_party/WebKit/LayoutTests/inspector/console/resources/invalidScript.js View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/SourceLocation.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8Initializer.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/V8LazyEventListener.cpp View 2 chunks +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/bindings/core/v8/WorkerOrWorkletScriptController.cpp View 4 chunks +7 lines, -20 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.cpp View 1 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/ErrorEvent.h View 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/events/ErrorEvent.cpp View 2 chunks +8 lines, -16 lines 0 comments Download
M third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp View 1 chunk +1 line, -1 line 2 comments Download

Dependent Patchsets:

Issue 2016123002 Patch 1
Issue 2016123002 Patch 20001
Issue 2016123002 Patch 40001

Messages

Total messages: 19 (9 generated)
dgozman
Could you please take a look?
4 years, 7 months ago (2016-05-25 02:43:58 UTC) #2
haraken
LGTM on my side.
4 years, 7 months ago (2016-05-25 03:22:15 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006893004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006893004/20001
4 years, 7 months ago (2016-05-26 21:25:04 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_compile_dbg_ng/builds/197078)
4 years, 6 months ago (2016-05-27 00:38:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2006893004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2006893004/20001
4 years, 6 months ago (2016-05-27 00:53:40 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 01:37:13 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/83aabb0c32bf01f588292dc992b135f7f2dd22ca Cr-Commit-Position: refs/heads/master@{#396346}
4 years, 6 months ago (2016-05-27 01:38:50 UTC) #15
sof
https://codereview.chromium.org/2006893004/diff/20001/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp File third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp (right): https://codereview.chromium.org/2006893004/diff/20001/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp#newcode173 third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp:173: ErrorEvent* event = ErrorEvent::create(errorMessage, location->clone(), nullptr); Doesn't the clone() ...
4 years, 6 months ago (2016-05-27 09:34:56 UTC) #17
sof
https://codereview.chromium.org/2006893004/diff/20001/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp File third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp (right): https://codereview.chromium.org/2006893004/diff/20001/third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp#newcode173 third_party/WebKit/Source/core/workers/InProcessWorkerMessagingProxy.cpp:173: ErrorEvent* event = ErrorEvent::create(errorMessage, location->clone(), nullptr); On 2016/05/27 09:34:55, ...
4 years, 6 months ago (2016-05-29 06:16:16 UTC) #18
dgozman
4 years, 6 months ago (2016-05-29 13:58:45 UTC) #19
Message was sent while issue was closed. 
Thanks for spotting! My bad indeed. I will work on this on Tuesday, after
vacation.

Powered by Google App Engine
This is Rietveld 408576698