[json] implement JSON.stringify gap pre-processing in C++.

[json] implement JSON.stringify gap pre-processing in C++.

This is in preparation of fully porting JSON.stringify to C++.

R=cbruni@chromium.org

Committed: https://crrev.com/c1f1e1ab98280275032ab19f5f90e0490251e9f5
Cr-Commit-Position: refs/heads/master@{#36449}

[Yang, 2016-05-23 11:53:30]

The CQ bit was checked by yangguo@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-05-23 11:53:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006663002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006663002/1

[commit-bot: I haz the power, 2016-05-23 12:30:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-23 12:30:31]

Dry run: This issue passed the CQ dry run.

[Camillo Bruni, 2016-05-23 14:08:25]

LGTM

https://codereview.chromium.org/2006663002/diff/1/src/json-stringifier.cc
File src/json-stringifier.cc (right):

https://codereview.chromium.org/2006663002/diff/1/src/json-stringifier.cc#new...
src/json-stringifier.cc:105: if
(class_name.is_identical_to(factory()->String_string())) {
argh :D we should have a IsNumberLike() somewhere :P.

https://codereview.chromium.org/2006663002/diff/1/src/json-stringifier.cc#new...
src/json-stringifier.cc:131: int gap_length = std::min(num_value, 10);
just read the spec, wut? :D

[Yang, 2016-05-23 18:19:08]

https://codereview.chromium.org/2006663002/diff/1/src/json-stringifier.cc
File src/json-stringifier.cc (right):

https://codereview.chromium.org/2006663002/diff/1/src/json-stringifier.cc#new...
src/json-stringifier.cc:105: if
(class_name.is_identical_to(factory()->String_string())) {
On 2016/05/23 14:08:25, Camillo Bruni wrote:
> argh :D we should have a IsNumberLike() somewhere :P.

Actually, the string case and the number case are different. The number
specifies the gap length, with whitespace. The string specifies the actual
indent string (which can be anything, up to 10 characters).

https://codereview.chromium.org/2006663002/diff/1/src/json-stringifier.cc#new...
src/json-stringifier.cc:131: int gap_length = std::min(num_value, 10);
On 2016/05/23 14:08:25, Camillo Bruni wrote:
> just read the spec, wut? :D

Yeah. Magic numbers ftw.

[Yang, 2016-05-23 18:19:12]

The CQ bit was checked by yangguo@chromium.org

[commit-bot: I haz the power, 2016-05-23 18:19:24]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2006663002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2006663002/1

[commit-bot: I haz the power, 2016-05-23 18:21:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-23 18:24:14]

Description was changed from

==========
[json] implement JSON.stringify gap pre-processing in C++.

This is in preparation of fully porting JSON.stringify to C++.

R=cbruni@chromium.org
==========

to

==========
[json] implement JSON.stringify gap pre-processing in C++.

This is in preparation of fully porting JSON.stringify to C++.

R=cbruni@chromium.org

Committed: https://crrev.com/c1f1e1ab98280275032ab19f5f90e0490251e9f5
Cr-Commit-Position: refs/heads/master@{#36449}
==========

[commit-bot: I haz the power, 2016-05-23 18:24:15]

Patchset 1 (id:??) landed as
https://crrev.com/c1f1e1ab98280275032ab19f5f90e0490251e9f5
Cr-Commit-Position: refs/heads/master@{#36449}