Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(471)

Issue 2002933002: [json] move json parser and stringifier into own compilation units. (Closed)

Created:
4 years, 7 months ago by Yang
Modified:
4 years, 7 months ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[json] move json parser and stringifier into own compilation units. This is a pure refactoring. R=cbruni@chromium.org Committed: https://crrev.com/bf705f0fd6cefa870acaff2850047f1d36602fd1 Cr-Commit-Position: refs/heads/master@{#36435}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -1739 lines) Patch
M BUILD.gn View 2 chunks +6 lines, -1 line 0 comments Download
M src/api.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M src/json-parser.h View 5 chunks +8 lines, -716 lines 0 comments Download
A + src/json-parser.cc View 19 chunks +106 lines, -223 lines 0 comments Download
M src/json-stringifier.h View 1 5 chunks +6 lines, -638 lines 0 comments Download
A + src/json-stringifier.cc View 1 15 chunks +22 lines, -139 lines 0 comments Download
M src/runtime/runtime.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/runtime/runtime-json.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M src/runtime/runtime-object.cc View 2 chunks +0 lines, -11 lines 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
Yang
4 years, 7 months ago (2016-05-23 09:20:56 UTC) #1
Camillo Bruni
Rubberstamp LGTM
4 years, 7 months ago (2016-05-23 09:30:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002933002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002933002/1
4 years, 7 months ago (2016-05-23 09:47:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: v8_android_arm_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_android_arm_compile_rel/builds/18025) v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, ...
4 years, 7 months ago (2016-05-23 09:48:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2002933002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2002933002/20001
4 years, 7 months ago (2016-05-23 09:59:20 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-23 10:35:34 UTC) #11
commit-bot: I haz the power
4 years, 7 months ago (2016-05-23 10:36:55 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bf705f0fd6cefa870acaff2850047f1d36602fd1
Cr-Commit-Position: refs/heads/master@{#36435}

Powered by Google App Engine
This is Rietveld 408576698