src/api.cc - Issue 2006663002: [json] implement JSON.stringify gap pre-processing in C++.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/api.cc

Issue 2006663002: [json] implement JSON.stringify gap pre-processing in C++. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@jsonrefactor

Patch Set: Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/api.cc

diff --git a/src/api.cc b/src/api.cc

index 416034f09da789e3b42911ecfa153a9f96129475..48be379ab82e81ca6bd27130776b23733b91904f 100644

--- a/src/api.cc

+++ b/src/api.cc

@@ -2778,8 +2778,8 @@ MaybeLocal<String> JSON::Stringify(Local<Context> context,

? isolate->factory()->empty_string()

: Utils::OpenHandle(*gap);

i::Handle<i::Object> maybe;

- has_pending_exception = !i::BasicJsonStringifier(isolate, gap_string)

- .Stringify(object)

+ has_pending_exception = !i::BasicJsonStringifier(isolate)

+ .Stringify(object, gap_string)

.ToHandle(&maybe);

RETURN_ON_FAILED_EXECUTION(String);

Local<String> result;

« no previous file with comments | « no previous file | src/js/json.js » ('j') | src/json-stringifier.cc » ('J')