[CSS Shapes] Remove deprecated shapes

[CSS Shapes] Remove deprecated shapes

Remove support for deprecated shape types and syntax. These have already been removed from the CSS Shapes specification, so this aligns the implementation with the specification.
    
The "new" tests below were simply moved from the old csswg directory, as they were the only tests there that applied to the current syntax.

Cheery-pick from http://trac.webkit.org/changeset/165472
BUG=354159
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169688

[rwlbuis, 2014-03-19 20:48:30]

PTAL

[rwlbuis, 2014-03-19 21:08:54]

Adding Eric for some advice. Eric, this change removes old syntax from before
the fork for -webkit-clip-path. If you look at this article about it:

http://www.html5rocks.com/en/tutorials/masking/adobe/

You'll see the old syntax:

circle(<cx>, <cy>, <r>)

However the latest CSS Masking spec simply links to CSS Shapes:

http://www.w3.org/TR/css-masking/#the-clip-path
http://dev.w3.org/csswg/css-shapes-2/#ltbasic-shapegt

where the new syntax is different, namely circle( [<shape-radius>]? [at
<position>]? )
(http://dev.w3.org/csswg/css-shapes-1/#supported-basic-shapes)

All other shapes changed syntax too AFAICS.

We have been supporting both syntaxes for a while but this change removes the
old one. WebKit already went ahead with this change. What would the best way to
deal with this be, an Intent to Remove?

[eseidel, 2014-03-19 21:11:59]

Intent to remove or just a PSA on blink-dev is fine.  I doubt this will matter
given that its prefixed and already removed by other browsers, but that just
makes the Intent easy. :)

[eseidel, 2014-03-19 21:13:55]

The goal with announcing is just to help make sure web devs know this is coming.
 Again, unlikely anyone cares much given we're the only browser left with this,
right?

rslgtm.

[Bem Jones-Bey (adobe), 2014-03-19 21:21:03]

Just a couple of things I noticed when going over the patch. :-)

https://codereview.chromium.org/200633005/diff/140001/LayoutTests/animations/...
File LayoutTests/animations/interpolation/shape-inside-expected.txt (right):

https://codereview.chromium.org/200633005/diff/140001/LayoutTests/animations/...
LayoutTests/animations/interpolation/shape-inside-expected.txt:6: FAIL:
[shape-inside: rectangle(37.5px, 37.5px, 25px, 25px)] is not supported
I'd feel better removing the tests than adding FAILs to the -expected.txt.

https://codereview.chromium.org/200633005/diff/140001/LayoutTests/animations/...
File LayoutTests/animations/interpolation/shape-outside-expected.txt (right):

https://codereview.chromium.org/200633005/diff/140001/LayoutTests/animations/...
LayoutTests/animations/interpolation/shape-outside-expected.txt:32: FAIL:
shape-outside from [circle(20% at right 10% bottom 20px)] to [circle(30% at
right 20% bottom 30px)] was [circle(25% at calc(((100% - 10%) * 0.5) + ((100% -
20%) * 0.5)) calc(((100% - 20px) * 0.5) + ((100% - 30px) * 0.5)))] at 0.5,
expected [circle(25% at left 85% bottom 25px)]
It looks like this FAIL was already here, but it would be great if you could fix
it or remove the test if it isn't useful anymore.

https://codereview.chromium.org/200633005/diff/140001/LayoutTests/css3/maskin...
File LayoutTests/css3/masking/clip-path-animation.html (right):

https://codereview.chromium.org/200633005/diff/140001/LayoutTests/css3/maskin...
LayoutTests/css3/masking/clip-path-animation.html:56: //     [1, "inset-box",
"webkitClipPath", "inset(10% 10% 10% 10% round 0px 0px 0px 0px / 0px 0px 0px
0px)", 0.05],
Can you put a FIXME saying why this is commented out here?

https://codereview.chromium.org/200633005/diff/140001/LayoutTests/css3/maskin...
LayoutTests/css3/masking/clip-path-animation.html:67: <div class="box"
id="inset-box"></div>
Shouldn't this be commented since the "expected values" portion is commented
out?

Maybe it would be better just to remove the inset test for now and put it back
when it works?

https://codereview.chromium.org/200633005/diff/140001/LayoutTests/fast/shapes...
File LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt (right):

https://codereview.chromium.org/200633005/diff/140001/LayoutTests/fast/shapes...
LayoutTests/fast/shapes/parsing/parsing-shape-inside-expected.txt:262: FAIL
getParentAndChildComputedStylesString("shape-inside", "circle(10px, 20px, 30px,
40px)", "inherit") should be parent: circle(10px, 20px, 30px, 40px, 0px, 0px),
child: circle(10px, 20px, 30px, 40px, 0px, 0px). Was parent: none, child: none.
You should fix these tests so they pass.

https://codereview.chromium.org/200633005/diff/140001/LayoutTests/fast/shapes...
File LayoutTests/fast/shapes/parsing/parsing-shape-lengths-expected.txt (right):

https://codereview.chromium.org/200633005/diff/140001/LayoutTests/fast/shapes...
LayoutTests/fast/shapes/parsing/parsing-shape-lengths-expected.txt:25: FAIL
getComputedStyleValue("shape-inside", "circle(1.5vmin at .5vmin 1vmin)") should
be circle(1.5vmin at 0.5vmin 1vmin). Was circle(9px at 3px 6px).
You should fix these tests, too.

https://codereview.chromium.org/200633005/diff/140001/LayoutTests/fast/shapes...
File LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt (right):

https://codereview.chromium.org/200633005/diff/140001/LayoutTests/fast/shapes...
LayoutTests/fast/shapes/parsing/parsing-shape-outside-expected.txt:261: FAIL
getParentAndChildComputedStylesString("shape-outside", "circle(10px, 20px, 30px,
40px)", "inherit") should be parent: circle(10px, 20px, 30px, 40px, 0px, 0px),
child: circle(10px, 20px, 30px, 40px, 0px, 0px). Was parent: none, child: none.
More fails that need to be fixed.

https://codereview.chromium.org/200633005/diff/140001/LayoutTests/fast/shapes...
File LayoutTests/fast/shapes/shape-inside/shape-inside-animation.html (right):

https://codereview.chromium.org/200633005/diff/140001/LayoutTests/fast/shapes...
LayoutTests/fast/shapes/shape-inside/shape-inside-animation.html:55: //   [1,
"inset-box", "shapeInside", "inset(10% 10% 10% 10% round 0px 0px 0px 0px / 0px
0px 0px 0px)", 0.05],
There should be a FIXME explaining why this is commented out, and all of the
other inset test machinery in this file should be commented as well. Or just
remove the disabled inset test completely for now and add it back later. I tend
to like the latter option, since I'm not a big fan of having commented out code
checked in.

https://codereview.chromium.org/200633005/diff/140001/Source/core/css/parser/...
File Source/core/css/parser/CSSPropertyParser.h (left):

https://codereview.chromium.org/200633005/diff/140001/Source/core/css/parser/...
Source/core/css/parser/CSSPropertyParser.h:173:
PassRefPtrWillBeRawPtr<CSSBasicShape>
parseDeprecatedBasicShapeCircle(CSSParserValueList* args);
Shouldn't this be removed?

https://codereview.chromium.org/200633005/diff/140001/Source/core/css/parser/...
Source/core/css/parser/CSSPropertyParser.h:175:
PassRefPtrWillBeRawPtr<CSSBasicShape>
parseDeprecatedBasicShapeEllipse(CSSParserValueList*);
Ditto.

[Bem Jones-Bey (adobe), 2014-03-20 18:56:22]

lgtm

[rwlbuis, 2014-03-20 19:04:33]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-03-20 19:04:34]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/200633005/200001

[commit-bot: I haz the power, 2014-03-20 19:08:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 19:08:05]

Try jobs failed on following builders:
  tryserver.blink on win_blink_rel

[rwlbuis, 2014-03-20 19:34:45]

The CQ bit was checked by rob.buis@samsung.com

[commit-bot: I haz the power, 2014-03-20 19:34:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rob.buis@samsung.com/200633005/200001

[commit-bot: I haz the power, 2014-03-20 20:38:21]

Change committed as 169688