Chromium Code Reviews Chromium Code Reviews
Issue 200633005:
[CSS Shapes] Remove deprecated shapes (Closed)
Base URL: https://chromium.googlesource.com/chromium/blink.git@master| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 | 2 |
| 3 <html> | 3 <html> |
| 4 <head> | 4 <head> |
| 5 <style> | 5 <style> |
| 6 .box { | 6 .box { |
| 7 height: 100px; | 7 height: 100px; |
| 8 width: 100px; | 8 width: 100px; |
| 9 margin: 10px; | 9 margin: 10px; |
| 10 display: inline-block; | 10 display: inline-block; |
| 11 } | 11 } |
| 12 | 12 |
| 13 #rectangle-box { | 13 #inset-box { |
| 14 -webkit-animation: rectangle-anim 2s linear | 14 -webkit-animation: inset-anim 2s linear |
| 15 } | 15 } |
| 16 | 16 |
| 17 #circle-box { | 17 #circle-box { |
| 18 -webkit-animation: circle-anim 2s linear | 18 -webkit-animation: circle-anim 2s linear |
| 19 } | 19 } |
| 20 | 20 |
| 21 #ellipse-box { | 21 #ellipse-box { |
| 22 -webkit-animation: ellipse-anim 2s linear | 22 -webkit-animation: ellipse-anim 2s linear |
| 23 } | 23 } |
| 24 | 24 |
| 25 #polygon-box { | 25 #polygon-box { |
| 26 -webkit-animation: polygon-anim 2s linear | 26 -webkit-animation: polygon-anim 2s linear |
| 27 } | 27 } |
| 28 | 28 |
| 29 | 29 |
| 30 @-webkit-keyframes rectangle-anim { | 30 @-webkit-keyframes inset-anim { |
| 31 from { shape-inside: rectangle(0%, 0%, 100%, 100%); } | 31 from { shape-inside: inset(0%); } |
| 32 to { shape-inside: rectangle(20%, 20%, 60%, 60%); } | 32 to { shape-inside: inset(20%); } |
| 33 } | 33 } |
| 34 | 34 |
| 35 @-webkit-keyframes circle-anim { | 35 @-webkit-keyframes circle-anim { |
| 36 from { shape-inside: circle(50% at 50% 50%); } | 36 from { shape-inside: circle(50% at 50% 50%); } |
| 37 to { shape-inside: circle(20% at 20% 20%); } | 37 to { shape-inside: circle(20% at 20% 20%); } |
| 38 } | 38 } |
| 39 | 39 |
| 40 @-webkit-keyframes ellipse-anim { | 40 @-webkit-keyframes ellipse-anim { |
| 41 from { shape-inside: ellipse(50% 40% at 50% 50%); } | 41 from { shape-inside: ellipse(50% 40% at 50% 50%); } |
| 42 to { shape-inside: ellipse(20% 20% at 20% 20%); } | 42 to { shape-inside: ellipse(20% 20% at 20% 20%); } |
| 43 } | 43 } |
| 44 | 44 |
| 45 @-webkit-keyframes polygon-anim { | 45 @-webkit-keyframes polygon-anim { |
| 46 from { shape-inside: polygon(nonzero, 0% 0%, 100% 0%, 100% 100%, 0% 100% ); } | 46 from { shape-inside: polygon(nonzero, 0% 0%, 100% 0%, 100% 100%, 0% 100% ); } |
| 47 to { shape-inside: polygon(nonzero, 20% 20%, 80% 20%, 80% 80%, 20% 80% ); } | 47 to { shape-inside: polygon(nonzero, 20% 20%, 80% 20%, 80% 80%, 20% 80% ); } |
| 48 } | 48 } |
| 49 | 49 |
| 50 </style> | 50 </style> |
| 51 <script src="../../../animations/resources/animation-test-helpers.js"></script > | 51 <script src="../../../animations/resources/animation-test-helpers.js"></script > |
| 52 <script type="text/javascript"> | 52 <script type="text/javascript"> |
| 53 const expectedValues = [ | 53 const expectedValues = [ |
| 54 // [time, element-id, property, expected-value, tolerance] | 54 // [time, element-id, property, expected-value, tolerance] |
| 55 [1, "rectangle-box", "shapeInside", "rectangle(10%, 10%, 80%, 80%, 0px, 0p x)", 0.05], | 55 // [1, "inset-box", "shapeInside", "inset(10% 10% 10% 10% round 0px 0px 0px 0px / 0px 0px 0px 0px)", 0.05], |
|
Bem Jones-Bey (adobe)
2014/03/19 21:21:04
There should be a FIXME explaining why this is com
| |
| 56 [1, "circle-box", "shapeInside", "circle(35% at 35% 35%)", 0.05], | 56 [1, "circle-box", "shapeInside", "circle(35% at 35% 35%)", 0.05], |
| 57 [1, "ellipse-box", "shapeInside", "ellipse(35% 30% at 35% 35%)", 0.05], | 57 [1, "ellipse-box", "shapeInside", "ellipse(35% 30% at 35% 35%)", 0.05], |
| 58 [1, "polygon-box", "shapeInside", "polygon(10% 10%, 90% 10%, 90% 90%, 10% 90%)", 0.05], | 58 [1, "polygon-box", "shapeInside", "polygon(10% 10%, 90% 10%, 90% 90%, 10% 90%)", 0.05], |
| 59 ]; | 59 ]; |
| 60 | 60 |
| 61 runAnimationTest(expectedValues); | 61 runAnimationTest(expectedValues); |
| 62 </script> | 62 </script> |
| 63 </head> | 63 </head> |
| 64 <body> | 64 <body> |
| 65 | 65 |
| 66 <div class="box" id="rectangle-box">Moving Text</div> | 66 <div class="box" id="inset-box">Moving Text</div> |
| 67 <div class="box" id="circle-box">Moving Text</div> | 67 <div class="box" id="circle-box">Moving Text</div> |
| 68 <div class="box" id="ellipse-box">Moving Text</div> | 68 <div class="box" id="ellipse-box">Moving Text</div> |
| 69 <div class="box" id="polygon-box">Moving Text</div> | 69 <div class="box" id="polygon-box">Moving Text</div> |
| 70 | 70 |
| 71 <div id="result"> | 71 <div id="result"> |
| 72 </div> | 72 </div> |
| 73 </body> | 73 </body> |
| 74 </html> | 74 </html> |
| OLD | NEW |
