Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2005193005: Disable fractional scroll feature by default (Closed)

Created:
4 years, 7 months ago by Rick Byers
Modified:
4 years, 6 months ago
Reviewers:
dtapuska
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@layout-test-fix
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Disable fractional scroll feature by default This feature is in a half-finished state and has regressed at some point. The primary use case will soon be addressed by bug 485650, we need to figure out what to do about the remaining use cases (eg. scroll while pinch-zoomed). In the interim, don't enable / test the partial code we have for this in blink unless the feature is explicitly enabled. I left support in the tests (though not the expected output files) so that we can easily find the affected tests later when we either resume work on the feature or remove it entirely. BUG=610460, 456622 Committed: https://crrev.com/8591ae927ed0dfafd977121533265d5cbc88a9fe Cr-Commit-Position: refs/heads/master@{#396476}

Patch Set 1 #

Patch Set 2 : Fix tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -116 lines) Patch
M third_party/WebKit/LayoutTests/fast/events/scale-and-scroll-div.html View 2 chunks +5 lines, -7 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/scale-and-scroll-div-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-scaled.html View 1 chunk +9 lines, -11 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-div-scaled-expected.txt View 2 chunks +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/scrolling/fractional-scroll-offset-document.html View 2 chunks +6 lines, -8 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/scrolling/fractional-scroll-offset-document-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/scrolling/scrolling-apis-subpixel.html View 1 chunk +9 lines, -9 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/scrolling/scrolling-apis-subpixel-expected.txt View 1 chunk +0 lines, -42 lines 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp View 1 2 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/tests/VisualViewportTest.cpp View 1 6 chunks +11 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Rick Byers
Dave, PTAL
4 years, 7 months ago (2016-05-26 03:07:54 UTC) #2
dtapuska
On 2016/05/26 03:07:54, Rick Byers wrote: > Dave, PTAL lgtm
4 years, 6 months ago (2016-05-27 13:36:52 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2005193005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2005193005/20001
4 years, 6 months ago (2016-05-27 15:10:22 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 15:54:50 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-05-27 15:56:12 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8591ae927ed0dfafd977121533265d5cbc88a9fe
Cr-Commit-Position: refs/heads/master@{#396476}

Powered by Google App Engine
This is Rietveld 408576698