Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Unified Diff: third_party/WebKit/LayoutTests/fast/scrolling/scrolling-apis-subpixel.html

Issue 2005193005: Disable fractional scroll feature by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@layout-test-fix
Patch Set: Fix tests Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/fast/scrolling/scrolling-apis-subpixel.html
diff --git a/third_party/WebKit/LayoutTests/fast/scrolling/scrolling-apis-subpixel.html b/third_party/WebKit/LayoutTests/fast/scrolling/scrolling-apis-subpixel.html
index c80f2e07ab938c805ee661264879e2215f0b2045..a8029dd9581463ac920f5832c13fb66f78b05517 100644
--- a/third_party/WebKit/LayoutTests/fast/scrolling/scrolling-apis-subpixel.html
+++ b/third_party/WebKit/LayoutTests/fast/scrolling/scrolling-apis-subpixel.html
@@ -72,16 +72,16 @@ function testPageZoom(zoom) {
testScroll(4.5, 4.5);
}
-debug("set PreferCompositingToLCDTextEnabled true");
-window.internals.settings.setPreferCompositingToLCDTextEnabled(true);
-testScroll(4.2, 4.2);
-testPageZoom(2);
-
-// If there is no browser zoom, floating point scroll offsets are truncated.
-// If there is browser zoom, we can still get fractional scroll offsets
-// through JS.
-debug("set PreferCompositingToLCDTextEnabled false");
+// By default we don't yet get fractional scroll offsets with more
+// granularity than the page zoom factor.
window.internals.settings.setPreferCompositingToLCDTextEnabled(false);
testScroll(4.2, 4);
testPageZoom(2);
+
+if (window.internals.runtimeFlags.fractionalScrollOffsetsEnabled) {
+ debug("Full fractional scroll offsets enabled");
+ window.internals.settings.setPreferCompositingToLCDTextEnabled(true);
+ testScroll(4.2, 4.2);
+ testPageZoom(2);
+}
</script>

Powered by Google App Engine
This is Rietveld 408576698