third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp - Issue 2005193005: Disable fractional scroll feature by default

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

Issue 2005193005: Disable fractional scroll feature by default (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@layout-test-fix

Patch Set: Fix tests Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in ('k') | third_party/WebKit/Source/web/tests/VisualViewportTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

diff --git a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

index 12ebf904b6d06bc8173d091a6770b53d24d314b2..77a3f1de3fcb47eff9c5538a0f18e14df6b34c0a 100644

--- a/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

+++ b/third_party/WebKit/Source/web/tests/ScrollingCoordinatorTest.cpp

@@ -153,6 +153,9 @@ TEST_F(ScrollingCoordinatorTest, fastScrollingCanBeDisabledWithSetting)

TEST_F(ScrollingCoordinatorTest, fastFractionalScrollingDiv)

{

+ bool origFractionalOffsetsEnabled = RuntimeEnabledFeatures::fractionalScrollOffsetsEnabled();

+ RuntimeEnabledFeatures::setFractionalScrollOffsetsEnabled(true);

registerMockedHttpURLLoad("fractional-scroll-div.html");

navigateTo(m_baseURL + "fractional-scroll-div.html");

forceFullCompositingUpdate();

@@ -182,6 +185,8 @@ TEST_F(ScrollingCoordinatorTest, fastFractionalScrollingDiv)

ASSERT_TRUE(webScrollLayer);

ASSERT_NEAR(1.2, webScrollLayer->scrollPositionDouble().x, 0.01);

ASSERT_NEAR(1.2, webScrollLayer->scrollPositionDouble().y, 0.01);

+ RuntimeEnabledFeatures::setFractionalScrollOffsetsEnabled(origFractionalOffsetsEnabled);

}

static WebLayer* webLayerFromElement(Element* element)