Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 2004963002: Rename delay_milliseconds to frames_delayed. (Closed)

Created:
4 years, 7 months ago by chcunningham
Modified:
4 years, 6 months ago
Reviewers:
DaleCurtis, o1ka
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename audio_delay_milliseconds to frames_delayed. The current name, delay_milliseconds, is misleading since the value is actually a count of frames since crrev.com/1687213002 BUG=604313 Committed: https://crrev.com/d49506b3d5dda08982bad081b99ec8a9abe5f331 Cr-Commit-Position: refs/heads/master@{#396535}

Patch Set 1 #

Patch Set 2 : Rebase, simplify #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M media/audio/audio_output_device_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/webaudiosourceprovider_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M media/blink/webaudiosourceprovider_impl.cc View 2 chunks +4 lines, -4 lines 1 comment Download
M media/blink/webaudiosourceprovider_impl_unittest.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download
M media/renderers/audio_renderer_impl.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/renderers/audio_renderer_impl_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
chcunningham
PS1 is a WIP - I'm finding that I have to plumb the sample rate ...
4 years, 7 months ago (2016-05-23 18:34:47 UTC) #1
chcunningham
PTAL Change to AudioConverter was blocking this (otherwise requiring additional frames / msec conversions to ...
4 years, 7 months ago (2016-05-26 21:39:33 UTC) #4
DaleCurtis
lgtm
4 years, 7 months ago (2016-05-27 02:44:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004963002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004963002/20001
4 years, 6 months ago (2016-05-27 17:51:02 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-05-27 19:42:36 UTC) #9
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d49506b3d5dda08982bad081b99ec8a9abe5f331 Cr-Commit-Position: refs/heads/master@{#396535}
4 years, 6 months ago (2016-05-27 19:43:41 UTC) #11
o1ka
4 years, 6 months ago (2016-05-30 08:07:42 UTC) #13
Message was sent while issue was closed.
Chris, please take a look at my comment. My impression is that
HtmlAudioElementCapturerSource::OnAudioBus operation is broken.

https://codereview.chromium.org/2004963002/diff/20001/media/blink/webaudiosou...
File media/blink/webaudiosourceprovider_impl.cc (right):

https://codereview.chromium.org/2004963002/diff/20001/media/blink/webaudiosou...
media/blink/webaudiosourceprovider_impl.cc:268:
copy_audio_bus_callback_.Run(std::move(bus_copy), frames_delayed,
HtmlAudioElementCapturerSource::OnAudioBus()
(https://cs-staging.chromium.org/chromium/src/content/renderer/media/html_audi...)
which ends up as copy_audio_bus_callback_ here
(https://cs-staging.chromium.org/chromium/src/content/renderer/media/html_audi...),
still interprets it as ms, isn't it?

Powered by Google App Engine
This is Rietveld 408576698