Blacklist rooksbas.dll in sandboxed processes

Blacklist rooksbas.dll in sandboxed processes

This is a source of many renderer hangs. See bug for more details.

BUG=609262
Committed: https://crrev.com/9a3648a17691625a13ee8acdb798813280193fb3
Cr-Commit-Position: refs/heads/master@{#395377}

[erikchen, 2016-05-20 23:00:52]

erikchen@chromium.org changed reviewers:
+ scottmg@chromium.org

[erikchen, 2016-05-20 23:00:52]

scottmg: Please review.

[erikchen, 2016-05-20 23:01:20]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2016-05-20 23:01:43]

erikchen@chromium.org changed reviewers:
+ avi@chromium.org

[erikchen, 2016-05-20 23:01:43]

+avi, for an actual content/ OWNER

[commit-bot: I haz the power, 2016-05-20 23:02:10]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004573003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004573003/1

[scottmg, 2016-05-20 23:02:35]

Description was changed from

==========
Blacklist rooksbas.dll in sandboxed processes

This is a source of many renderer hangs. See bug for more details.

BUG=609262
==========

to

==========
Blacklist rooksbas.dll in sandboxed processes

This is a source of many renderer hangs. See bug for more details.

BUG=609262
==========

[scottmg, 2016-05-20 23:02:35]

scottmg@chromium.org changed reviewers:
+ jschuh@chromium.org, wfh@chromium.org
- avi@chromium.org

[scottmg, 2016-05-20 23:03:49]

sandbox_win is noparent, wfh or jschuh can hook you up.

lgtm

[
i would 'not l-g-t-m' the rollback of this >:-(
]

[Will Harris, 2016-05-20 23:20:51]

On 2016/05/20 23:03:49, scottmg (ooo until 24may) wrote:
> sandbox_win is noparent, wfh or jschuh can hook you up.
> 
> lgtm
> 
> [
> i would 'not l-g-t-m' the rollback of this >:-(
> ]

lgtm but please notify csharp@ as he knows full process for this.

[erikchen, 2016-05-20 23:52:38]

erikchen@chromium.org changed reviewers:
+ csharp@chromium.org, taviso@google.com

[erikchen, 2016-05-20 23:52:38]

+csharp, taviso.

This is a stability issue, and this particular module was recently
blacklisted/unblacklisted:
https://codereview.chromium.org/2004573003/

Should I do anything beyond sending email to
chrome-blacklisting-announce@chromium.org?
(https://www.chromium.org/Home/third-party-developers#TOC-Google-Chrome-s-DLL-...)

[commit-bot: I haz the power, 2016-05-21 00:46:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-05-21 00:46:34]

Dry run: This issue passed the CQ dry run.

[Avi (use Gerrit), 2016-05-22 00:03:03]

avi@chromium.org changed reviewers:
+ avi@chromium.org

[Avi (use Gerrit), 2016-05-22 00:03:04]

lgtm

[erikchen, 2016-05-23 17:29:49]

On 2016/05/22 00:03:04, Avi wrote:
> lgtm

We're cutting M51 tomorrow, so this has to land soon. I haven't been able to get
a hold of taviso@ or csharp@. I'm going to land this CL, merge to M51, and send
mail to the appropriate lists.

[erikchen, 2016-05-23 17:30:00]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-05-23 17:30:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2004573003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/2004573003/1

[taviso1, 2016-05-23 18:02:41]

LGTM, what they're doing makes no sense whatsoever.

[Will Harris, 2016-05-23 18:44:29]

This message is to notify to chrome-blacklisting-announce@chromium.org that
these two DLLs are being blacklisted from Chromium renderer processes:

rooksbas.dll
rooksbas_x64.dll

[commit-bot: I haz the power, 2016-05-23 18:54:03]

Description was changed from

==========
Blacklist rooksbas.dll in sandboxed processes

This is a source of many renderer hangs. See bug for more details.

BUG=609262
==========

to

==========
Blacklist rooksbas.dll in sandboxed processes

This is a source of many renderer hangs. See bug for more details.

BUG=609262
==========

[commit-bot: I haz the power, 2016-05-23 18:54:04]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-05-23 18:55:20]

Description was changed from

==========
Blacklist rooksbas.dll in sandboxed processes

This is a source of many renderer hangs. See bug for more details.

BUG=609262
==========

to

==========
Blacklist rooksbas.dll in sandboxed processes

This is a source of many renderer hangs. See bug for more details.

BUG=609262

Committed: https://crrev.com/9a3648a17691625a13ee8acdb798813280193fb3
Cr-Commit-Position: refs/heads/master@{#395377}
==========

[commit-bot: I haz the power, 2016-05-23 18:55:21]

Patchset 1 (id:??) landed as
https://crrev.com/9a3648a17691625a13ee8acdb798813280193fb3
Cr-Commit-Position: refs/heads/master@{#395377}

[erikchen, 2016-05-24 17:49:50]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2003373003/ by erikchen@chromium.org.

The reason for reverting is: This causes full browser hangs when the Trusteer
Rapport product is enabled. We probably need to also blacklist dlls from the
browser process..