Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(337)

Issue 2003373003: Revert of Blacklist rooksbas.dll in sandboxed processes (Closed)

Created:
4 years, 7 months ago by erikchen
Modified:
4 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, rickyz+watch_chromium.org, Avi (use Gerrit), chrome-blacklisting-announce_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Blacklist rooksbas.dll in sandboxed processes (patchset #1 id:1 of https://codereview.chromium.org/2004573003/ ) Reason for revert: This causes full browser hangs when the Trusteer Rapport product is enabled. We probably need to also blacklist dlls from the browser process. Original issue's description: > Blacklist rooksbas.dll in sandboxed processes > > This is a source of many renderer hangs. See bug for more details. > > BUG=609262 > > Committed: https://crrev.com/9a3648a17691625a13ee8acdb798813280193fb3 > Cr-Commit-Position: refs/heads/master@{#395377} TBR=scottmg@chromium.org,jschuh@chromium.org,wfh@chromium.org,csharp@chromium.org,taviso@google.com,avi@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=609262 Committed: https://crrev.com/b23298a9a5a768197031c529cb7c26f992f3446e Cr-Commit-Position: refs/heads/master@{#395635}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M content/common/sandbox_win.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
erikchen
Created Revert of Blacklist rooksbas.dll in sandboxed processes
4 years, 7 months ago (2016-05-24 17:49:50 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003373003/1
4 years, 7 months ago (2016-05-24 17:50:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-24 17:51:06 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b23298a9a5a768197031c529cb7c26f992f3446e Cr-Commit-Position: refs/heads/master@{#395635}
4 years, 7 months ago (2016-05-24 17:56:30 UTC) #5
csharp
4 years, 7 months ago (2016-05-24 18:11:08 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698