Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2004253002: media: More cleanup in cdm_paths.* (Closed)

Created:
4 years, 7 months ago by xhwang
Modified:
4 years, 7 months ago
Reviewers:
jrummell
CC:
chromium-reviews, yusukes+watch_chromium.org, feature-media-reviews_chromium.org, binji+watch_chromium.org, tzik, eme-reviews_chromium.org, teravest+watch_chromium.org, bradnelson+warch_chromium.org, piman+watch_chromium.org, ihf+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

media: More cleanup in cdm_paths.* This makes cdm_paths.{cc|gypi|gni} more consistent with each other. Also, further limit where we use platform specific paths so that we don't end up building clearkeycdm into _platform_specific/win_unsupported_arch/ on Windows MIPS (in theory). BUG=582622 Committed: https://crrev.com/27986d67c03bfc2b79a949c40f8e365791a1e613 Cr-Commit-Position: refs/heads/master@{#395631}

Patch Set 1 #

Patch Set 2 : further limit where we use platform specific path #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -9 lines) Patch
M media/cdm/cdm_paths.cc View 1 2 chunks +3 lines, -2 lines 0 comments Download
M media/cdm/ppapi/cdm_paths.gni View 1 1 chunk +9 lines, -4 lines 0 comments Download
M media/cdm_paths.gypi View 1 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
xhwang
jrummell: some minor cleanup. PTAL
4 years, 7 months ago (2016-05-24 16:14:32 UTC) #3
jrummell
lgtm
4 years, 7 months ago (2016-05-24 17:32:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2004253002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2004253002/20001
4 years, 7 months ago (2016-05-24 17:35:20 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-05-24 17:40:04 UTC) #8
commit-bot: I haz the power
4 years, 7 months ago (2016-05-24 17:42:43 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/27986d67c03bfc2b79a949c40f8e365791a1e613
Cr-Commit-Position: refs/heads/master@{#395631}

Powered by Google App Engine
This is Rietveld 408576698