Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Side by Side Diff: media/cdm/ppapi/cdm_paths.gni

Issue 2004253002: media: More cleanup in cdm_paths.* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: further limit where we use platform specific path Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/cdm/cdm_paths.cc ('k') | media/cdm_paths.gypi » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # This file defines output paths for the CDM adapters and CDMs. 5 # This file defines output paths for the CDM adapters and CDMs.
6 6
7 # Naming and folder structure below are following the recommendation for Chrome 7 # Naming and folder structure below are following the recommendation for Chrome
8 # components. Component-updated CDMs must follow the same recommendation. 8 # components. Component-updated CDMs must follow the same recommendation.
9 9
10 # Note: This file must be in sync with cdm_paths.cc 10 # Note: This file must be in sync with cdm_paths.cc
11 11
12 # OS name for components is close to "target_os" but has some differences. 12 # OS name for components is close to "target_os" but has some differences.
13 # Explicitly define what we use to avoid confusion. 13 # Explicitly define what we use to avoid confusion.
14 if (is_chromeos) { 14 if (is_chromeos) {
15 component_os = "cros" 15 component_os = "cros"
16 } else if (is_linux) { 16 } else if (is_linux) {
17 component_os = "linux" 17 component_os = "linux"
18 } else if (is_win) { 18 } else if (is_win) {
19 component_os = "win" 19 component_os = "win"
20 } else if (is_mac) { 20 } else if (is_mac) {
21 component_os = "mac" 21 component_os = "mac"
22 } else { 22 } else {
23 component_os = "$target_os" 23 component_os = "unsupported_platform"
24 }
25
26 if (target_cpu == "x86" || target_cpu == "x64" || target_cpu == "arm") {
27 component_arch = "$target_cpu"
28 } else {
29 component_arch = "unsupported_arch"
24 } 30 }
25 31
26 # Only enable platform specific path for Win and Mac, where CDMs are Chrome 32 # Only enable platform specific path for Win and Mac, where CDMs are Chrome
27 # components. 33 # components.
28 # TODO(xhwang): Improve how we enable platform specific path. See 34 # TODO(xhwang): Improve how we enable platform specific path. See
29 # http://crbug.com/468584 35 # http://crbug.com/468584
30 if (is_win || is_mac) { 36 if ((is_win || is_mac) && (target_cpu == "x86" || target_cpu == "x64")) {
31 # Architecture name for components is the same as "<(target_cpu)".
32 _platform_specific_path = 37 _platform_specific_path =
33 "_platform_specific/$component_os" + "_" + "$target_cpu" 38 "_platform_specific/$component_os" + "_" + "$component_arch"
34 39
35 # Path of Clear Key and Widevine CDMs relative to the output dir. 40 # Path of Clear Key and Widevine CDMs relative to the output dir.
36 clearkey_cdm_path = "ClearKeyCdm/$_platform_specific_path" 41 clearkey_cdm_path = "ClearKeyCdm/$_platform_specific_path"
37 widevine_cdm_path = "WidevineCdm/$_platform_specific_path" 42 widevine_cdm_path = "WidevineCdm/$_platform_specific_path"
38 } else { 43 } else {
39 clearkey_cdm_path = "." 44 clearkey_cdm_path = "."
40 widevine_cdm_path = "." 45 widevine_cdm_path = "."
41 } 46 }
OLDNEW
« no previous file with comments | « media/cdm/cdm_paths.cc ('k') | media/cdm_paths.gypi » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698