Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: media/cdm/cdm_paths.cc

Issue 2004253002: media: More cleanup in cdm_paths.* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: further limit where we use platform specific path Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | media/cdm/ppapi/cdm_paths.gni » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/cdm/cdm_paths.h" 5 #include "media/cdm/cdm_paths.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "build/build_config.h" 9 #include "build/build_config.h"
10 10
11 namespace media { 11 namespace media {
12 12
13 // Note: This file must be in sync with cdm_paths.{gypi|gni} 13 // Note: This file must be in sync with cdm_paths.{gypi|gni}
14 // TODO(xhwang): Improve how we enable platform specific path. See 14 // TODO(xhwang): Improve how we enable platform specific path. See
15 // http://crbug.com/468584 15 // http://crbug.com/468584
16 #if defined(OS_MACOSX) || defined(OS_WIN) 16 #if (defined(OS_MACOSX) || defined(OS_WIN)) && \
17 (defined(ARCH_CPU_X86) || defined(ARCH_CPU_X86_64))
17 #define CDM_USE_PLATFORM_SPECIFIC_PATH 18 #define CDM_USE_PLATFORM_SPECIFIC_PATH
18 #endif 19 #endif
19 20
20 #if defined(CDM_USE_PLATFORM_SPECIFIC_PATH) 21 #if defined(CDM_USE_PLATFORM_SPECIFIC_PATH)
21 22
22 // Special path used in chrome components. 23 // Special path used in chrome components.
23 const char kPlatformSpecific[] = "_platform_specific"; 24 const char kPlatformSpecific[] = "_platform_specific";
24 25
25 // Name of the component platform in the manifest. 26 // Name of the component platform in the manifest.
26 const char kComponentPlatform[] = 27 const char kComponentPlatform[] =
27 #if defined(OS_MACOSX) 28 #if defined(OS_MACOSX)
28 "mac"; 29 "mac";
29 #elif defined(OS_WIN) 30 #elif defined(OS_WIN)
30 "win"; 31 "win";
31 #elif defined(OS_CHROMEOS) 32 #elif defined(OS_CHROMEOS)
32 "chromeos"; 33 "cros";
33 #elif defined(OS_LINUX) 34 #elif defined(OS_LINUX)
34 "linux"; 35 "linux";
35 #else 36 #else
36 "unsupported_platform"; 37 "unsupported_platform";
37 #endif 38 #endif
38 39
39 // Name of the component architecture in the manifest. 40 // Name of the component architecture in the manifest.
40 const char kComponentArch[] = 41 const char kComponentArch[] =
41 #if defined(ARCH_CPU_X86) 42 #if defined(ARCH_CPU_X86)
42 "x86"; 43 "x86";
(...skipping 16 matching lines...) Expand all
59 60
60 #else // defined(CDM_USE_PLATFORM_SPECIFIC_PATH) 61 #else // defined(CDM_USE_PLATFORM_SPECIFIC_PATH)
61 62
62 base::FilePath GetPlatformSpecificDirectory(const std::string& cdm_base_path) { 63 base::FilePath GetPlatformSpecificDirectory(const std::string& cdm_base_path) {
63 return base::FilePath(); 64 return base::FilePath();
64 } 65 }
65 66
66 #endif // defined(CDM_USE_PLATFORM_SPECIFIC_PATH) 67 #endif // defined(CDM_USE_PLATFORM_SPECIFIC_PATH)
67 68
68 } // namespace media 69 } // namespace media
OLDNEW
« no previous file with comments | « no previous file | media/cdm/ppapi/cdm_paths.gni » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698