Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2003793002: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in PlainTextRange. (Closed)

Created:
4 years, 7 months ago by dglazkov
Modified:
4 years, 5 months ago
Reviewers:
esprehn
CC:
blink-reviews, blink-reviews-style_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in PlainTextRange. R=esprehn BUG=590369 Committed: https://crrev.com/77d3f608442242cdd7cc5bf672dfca9abe32bbab Cr-Commit-Position: refs/heads/master@{#404887}

Patch Set 1 #

Patch Set 2 : Iteration 2. #

Patch Set 3 : Retreat! Retreat! #

Patch Set 4 : 3rd Wave. #

Patch Set 5 : Updated some comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -4 lines) Patch
M third_party/WebKit/Source/core/editing/InputMethodController.cpp View 1 2 3 4 3 chunks +12 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/PlainTextRange.cpp View 3 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/ApplyStyleCommand.cpp View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp View 1 2 3 4 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 2 3 4 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebRange.cpp View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 41 (21 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003793002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003793002/1
4 years, 7 months ago (2016-05-20 20:53:33 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/225975)
4 years, 7 months ago (2016-05-20 22:37:06 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003793002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003793002/20001
4 years, 7 months ago (2016-05-20 23:19:13 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/226091)
4 years, 7 months ago (2016-05-21 00:22:22 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003793002/40001
4 years, 7 months ago (2016-05-21 04:17:11 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233399)
4 years, 7 months ago (2016-05-21 06:49:47 UTC) #12
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003793002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003793002/40001
4 years, 7 months ago (2016-05-21 14:57:02 UTC) #14
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-21 16:05:31 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003793002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003793002/60001
4 years, 7 months ago (2016-05-21 22:44:27 UTC) #18
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233458)
4 years, 7 months ago (2016-05-22 01:12:27 UTC) #20
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003793002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003793002/60001
4 years, 7 months ago (2016-05-22 03:59:35 UTC) #22
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/233474)
4 years, 7 months ago (2016-05-22 06:30:07 UTC) #24
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003793002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003793002/60001
4 years, 7 months ago (2016-05-22 15:23:57 UTC) #26
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 7 months ago (2016-05-22 16:27:44 UTC) #28
esprehn
this lgtm, are there asserts to catch when we screw up moving these around?
4 years, 6 months ago (2016-06-01 06:21:30 UTC) #29
dglazkov
On 2016/06/01 at 06:21:30, esprehn wrote: > this lgtm, are there asserts to catch when ...
4 years, 5 months ago (2016-07-12 18:17:47 UTC) #30
dglazkov
Updated some comments.
4 years, 5 months ago (2016-07-12 18:21:17 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2003793002/80001
4 years, 5 months ago (2016-07-12 21:14:15 UTC) #38
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 5 months ago (2016-07-13 02:06:47 UTC) #39
commit-bot: I haz the power
4 years, 5 months ago (2016-07-13 02:08:47 UTC) #41
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/77d3f608442242cdd7cc5bf672dfca9abe32bbab
Cr-Commit-Position: refs/heads/master@{#404887}

Powered by Google App Engine
This is Rietveld 408576698