Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Side by Side Diff: third_party/WebKit/Source/web/WebRange.cpp

Issue 2003793002: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in PlainTextRange. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Updated some comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 { 72 {
73 return m_private->text(); 73 return m_private->text();
74 } 74 }
75 75
76 // static 76 // static
77 WebRange WebRange::fromDocumentRange(WebLocalFrame* frame, int start, int length ) 77 WebRange WebRange::fromDocumentRange(WebLocalFrame* frame, int start, int length )
78 { 78 {
79 LocalFrame* webFrame = toWebLocalFrameImpl(frame)->frame(); 79 LocalFrame* webFrame = toWebLocalFrameImpl(frame)->frame();
80 Element* selectionRoot = webFrame->selection().rootEditableElement(); 80 Element* selectionRoot = webFrame->selection().rootEditableElement();
81 ContainerNode* scope = selectionRoot ? selectionRoot : webFrame->document()- >documentElement(); 81 ContainerNode* scope = selectionRoot ? selectionRoot : webFrame->document()- >documentElement();
82
83 // TODO(dglazkov): The use of updateStyleAndLayoutIgnorePendingStylesheets n eeds to be audited.
84 // see http://crbug.com/590369 for more details.
85 scope->document().updateStyleAndLayoutIgnorePendingStylesheets();
86
82 return createRange(PlainTextRange(start, start + length).createRange(*scope) ); 87 return createRange(PlainTextRange(start, start + length).createRange(*scope) );
83 } 88 }
84 89
85 WebRange::WebRange(Range*range) 90 WebRange::WebRange(Range*range)
86 : m_private(range) 91 : m_private(range)
87 { 92 {
88 } 93 }
89 94
90 WebRange::operator Range*() const 95 WebRange::operator Range*() const
91 { 96 {
92 return m_private.get(); 97 return m_private.get();
93 } 98 }
94 99
95 } // namespace blink 100 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698