third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp - Issue 2003793002: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in PlainTextRange.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

Issue 2003793002: Audit the use of updateStyleAndLayoutIgnorePendingStylesheets in PlainTextRange. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated some comments. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp ('k') | third_party/WebKit/Source/modules/accessibility/AXLayoutObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

index 9797b957683469d3793dd9216ba94f6e28e5ff49..d9dc694304fe25381e6ffb0da5d7c8735c2cfd3c 100644

--- a/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/InsertListCommand.cpp

@@ -187,6 +187,11 @@ void InsertListCommand::doApply(EditingState* editingState)

if (!singleParagraphResult)

break;

if (endOfSelection.isNull() || endOfSelection.isOrphan() || startOfLastParagraph.isNull() || startOfLastParagraph.isOrphan()) {

+ // TODO(dglazkov): The use of updateStyleAndLayoutIgnorePendingStylesheets needs to be audited.

+ // see http://crbug.com/590369 for more details.

+ document().updateStyleAndLayoutIgnorePendingStylesheets();

endOfSelection = visiblePositionForIndex(indexForEndOfSelection, scopeForEndOfSelection);

// If endOfSelection is null, then some contents have been deleted from the document.

// This should never happen and if it did, exit early immediately because we've lost the loop invariant.