Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2003653002:
Use SkASSERTResult to avoid unused local variables (Closed)
DescriptionUse SkASSERTResult to avoid unused local variables
BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2003653002
Committed: https://skia.googlesource.com/skia/+/beb1c67c9d332b41b306b292bb77a0e1566c32a8
Patch Set 1 #Patch Set 2 : Name #
Total comments: 2
Messages
Total messages: 21 (10 generated)
Description was changed from ========== Use SkASSERTResult to avoid unused local variables BUG=skia: ========== to ========== Use SkASSERTResult to avoid unused local variables BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2003653002 ==========
Description was changed from ========== Use SkASSERTResult to avoid unused local variables BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2003653002 ========== to ========== Use SkASSERTResult to avoid unused local variables BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2003653002 ==========
liyuqian@google.com changed reviewers: + ethannicholas@google.com, jvanverth@google.com
Thanks and here's the fix with SkAssertResult :)
lgtm
The CQ bit was checked by liyuqian@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003653002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)
The CQ bit was checked by liyuqian@google.com to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003653002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by liyuqian@google.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2003653002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2003653002/20001
Message was sent while issue was closed.
Description was changed from ========== Use SkASSERTResult to avoid unused local variables BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2003653002 ========== to ========== Use SkASSERTResult to avoid unused local variables BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2003653002 Committed: https://skia.googlesource.com/skia/+/beb1c67c9d332b41b306b292bb77a0e1566c32a8 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as https://skia.googlesource.com/skia/+/beb1c67c9d332b41b306b292bb77a0e1566c32a8
Message was sent while issue was closed.
egdaniel@google.com changed reviewers: + egdaniel@google.com
Message was sent while issue was closed.
https://codereview.chromium.org/2003653002/diff/20001/tools/viewer/sk_app/and... File tools/viewer/sk_app/android/surface_glue_android.cpp (right): https://codereview.chromium.org/2003653002/diff/20001/tools/viewer/sk_app/and... tools/viewer/sk_app/android/surface_glue_android.cpp:84: SkAssertResult(read(fPipes[0], message, sizeof(Message)) == sizeof(Message)); So just doing a fly by unsolicited review. Here would it be better to have just surrounded the "auto read/writeSize =" in SkDEBUGCODE(...) so we don't do the compare on release?
Message was sent while issue was closed.
https://codereview.chromium.org/2003653002/diff/20001/tools/viewer/sk_app/and... File tools/viewer/sk_app/android/surface_glue_android.cpp (right): https://codereview.chromium.org/2003653002/diff/20001/tools/viewer/sk_app/and... tools/viewer/sk_app/android/surface_glue_android.cpp:84: SkAssertResult(read(fPipes[0], message, sizeof(Message)) == sizeof(Message)); On 2016/05/20 18:50:23, egdaniel wrote: > So just doing a fly by unsolicited review. Here would it be better to have just > surrounded the "auto read/writeSize =" in SkDEBUGCODE(...) so we don't do the > compare on release? That's a good point. However, I've already committed the change... Shall I create another CL?
Message was sent while issue was closed.
On 2016/05/20 18:53:00, liyuqian wrote: > https://codereview.chromium.org/2003653002/diff/20001/tools/viewer/sk_app/and... > File tools/viewer/sk_app/android/surface_glue_android.cpp (right): > > https://codereview.chromium.org/2003653002/diff/20001/tools/viewer/sk_app/and... > tools/viewer/sk_app/android/surface_glue_android.cpp:84: > SkAssertResult(read(fPipes[0], message, sizeof(Message)) == sizeof(Message)); > On 2016/05/20 18:50:23, egdaniel wrote: > > So just doing a fly by unsolicited review. Here would it be better to have > just > > surrounded the "auto read/writeSize =" in SkDEBUGCODE(...) so we don't do the > > compare on release? > > That's a good point. However, I've already committed the change... Shall I > create another CL? Sure |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
