tools/viewer/Viewer.cpp - Issue 2003653002: Use SkASSERTResult to avoid unused local variables

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/viewer/Viewer.cpp

Issue 2003653002: Use SkASSERTResult to avoid unused local variables (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Name Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/viewer/Viewer.cpp

diff --git a/tools/viewer/Viewer.cpp b/tools/viewer/Viewer.cpp

index a0b2a2abe3ca53505895be1c8a7969fd526d0226..c4b8b26dc51e3fda5a43a66962f5dba0a397de0d 100644

--- a/tools/viewer/Viewer.cpp

+++ b/tools/viewer/Viewer.cpp

@@ -223,8 +223,7 @@ void Viewer::setupCurrentSlide(int previousSlide) {

const SkRect slideBounds = SkRect::MakeIWH(slideSize.width(), slideSize.height());

if (contentRect.width() > 0 && contentRect.height() > 0) {

fDefaultMatrix.setRectToRect(slideBounds, contentRect, SkMatrix::kStart_ScaleToFit);

- bool inverted = fDefaultMatrix.invert(&fDefaultMatrixInv);

- SkASSERT(inverted);

+ SkAssertResult(fDefaultMatrix.invert(&fDefaultMatrixInv));

}